[PATCH v1 0/4] s390x CPU Models: Fix deprecated_features='on'

Collin Walling posted 4 patches 2 months, 2 weeks ago
Failed in applying to current master (apply log)
src/qemu/qemu_capabilities.c                  | 106 ++++++++++++------
src/qemu/qemu_monitor.c                       |   6 +-
src/qemu/qemu_monitor.h                       |   3 +-
src/qemu/qemu_monitor_json.c                  |  17 ++-
.../caps_10.0.0_s390x.xml                     |   6 +
.../qemucapabilitiesdata/caps_9.1.0_s390x.xml |   6 +
.../qemucapabilitiesdata/caps_9.2.0_s390x.xml |   6 +
7 files changed, 112 insertions(+), 38 deletions(-)
[PATCH v1 0/4] s390x CPU Models: Fix deprecated_features='on'
Posted by Collin Walling 2 months, 2 weeks ago
Currently, when setting the deprecated_features attribute to 'on', all
known deprecated features will be enabled for the CPU model, including
ones that are *not* supported by the model.

These patches query an additional set of deprecated features by performing
a CPU model expansion on host-model with type "static".  The list of 
deprecated features reported from this command will reflect features that 
may be enabled on the model without error.  Now, when a user specifies
deprecated_features='on' in the domain XML, only the features that are
still supported by the model are requested to be turned on for the guest.

This can be helpful for e.g. tests that may wish to check CPU model
compatability in certain environments.

Collin Walling (4):
  qemu: rename modelinfo's deprecated_props to full_dep_props
  qemu: refactor load/format of deprecated features
  qemu: query and cache static/host deprecated features
  qemu: only allow enabling deprecated features that are supported

 src/qemu/qemu_capabilities.c                  | 106 ++++++++++++------
 src/qemu/qemu_monitor.c                       |   6 +-
 src/qemu/qemu_monitor.h                       |   3 +-
 src/qemu/qemu_monitor_json.c                  |  17 ++-
 .../caps_10.0.0_s390x.xml                     |   6 +
 .../qemucapabilitiesdata/caps_9.1.0_s390x.xml |   6 +
 .../qemucapabilitiesdata/caps_9.2.0_s390x.xml |   6 +
 7 files changed, 112 insertions(+), 38 deletions(-)

-- 
2.51.1
Re: [PATCH v1 0/4] s390x CPU Models: Fix deprecated_features='on'
Posted by Jiri Denemark via Devel 2 months, 2 weeks ago
On Thu, Nov 20, 2025 at 17:34:39 -0500, Collin Walling wrote:
> Currently, when setting the deprecated_features attribute to 'on', all
> known deprecated features will be enabled for the CPU model, including
> ones that are *not* supported by the model.
> 
> These patches query an additional set of deprecated features by performing
> a CPU model expansion on host-model with type "static".  The list of 
> deprecated features reported from this command will reflect features that 
> may be enabled on the model without error.  Now, when a user specifies
> deprecated_features='on' in the domain XML, only the features that are
> still supported by the model are requested to be turned on for the guest.
> 
> This can be helpful for e.g. tests that may wish to check CPU model
> compatability in certain environments.
> 
> Collin Walling (4):
>   qemu: rename modelinfo's deprecated_props to full_dep_props
>   qemu: refactor load/format of deprecated features
>   qemu: query and cache static/host deprecated features
>   qemu: only allow enabling deprecated features that are supported
> 
>  src/qemu/qemu_capabilities.c                  | 106 ++++++++++++------
>  src/qemu/qemu_monitor.c                       |   6 +-
>  src/qemu/qemu_monitor.h                       |   3 +-
>  src/qemu/qemu_monitor_json.c                  |  17 ++-
>  .../caps_10.0.0_s390x.xml                     |   6 +
>  .../qemucapabilitiesdata/caps_9.1.0_s390x.xml |   6 +
>  .../qemucapabilitiesdata/caps_9.2.0_s390x.xml |   6 +
>  7 files changed, 112 insertions(+), 38 deletions(-)

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>