[PATCH 0/2] bhyve: support VNC 'wait' attribute

Roman Bogorodskiy posted 2 patches 2 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20251119175427.55587-1-bogorodskiy@gmail.com
src/bhyve/bhyve_command.c                     |  3 ++
src/conf/domain_conf.c                        | 11 +++++
src/conf/domain_conf.h                        |  1 +
src/conf/schemas/domaincommon.rng             |  5 +++
.../bhyvexml2argv-vnc-wait-no.args            | 13 ++++++
.../bhyvexml2argv-vnc-wait-no.ldargs          |  1 +
.../bhyvexml2argv-vnc-wait-no.xml             | 26 +++++++++++
.../bhyvexml2argv-vnc-wait.args               | 13 ++++++
.../bhyvexml2argv-vnc-wait.ldargs             |  1 +
.../bhyvexml2argv-vnc-wait.xml                | 26 +++++++++++
tests/bhyvexml2argvtest.c                     |  2 +
.../bhyvexml2xmlout-vnc-wait-no.xml           | 44 +++++++++++++++++++
.../bhyvexml2xmlout-vnc-wait.xml              | 44 +++++++++++++++++++
tests/bhyvexml2xmltest.c                      |  2 +
14 files changed, 192 insertions(+)
create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc-wait-no.args
create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc-wait-no.ldargs
create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc-wait-no.xml
create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc-wait.args
create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc-wait.ldargs
create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc-wait.xml
create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-wait-no.xml
create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-wait.xml
[PATCH 0/2] bhyve: support VNC 'wait' attribute
Posted by Roman Bogorodskiy 2 months, 2 weeks ago
Roman Bogorodskiy (2):
  conf: introduce 'wait' attribute for VNC
  bhyve: support VNC 'wait' attribute

 src/bhyve/bhyve_command.c                     |  3 ++
 src/conf/domain_conf.c                        | 11 +++++
 src/conf/domain_conf.h                        |  1 +
 src/conf/schemas/domaincommon.rng             |  5 +++
 .../bhyvexml2argv-vnc-wait-no.args            | 13 ++++++
 .../bhyvexml2argv-vnc-wait-no.ldargs          |  1 +
 .../bhyvexml2argv-vnc-wait-no.xml             | 26 +++++++++++
 .../bhyvexml2argv-vnc-wait.args               | 13 ++++++
 .../bhyvexml2argv-vnc-wait.ldargs             |  1 +
 .../bhyvexml2argv-vnc-wait.xml                | 26 +++++++++++
 tests/bhyvexml2argvtest.c                     |  2 +
 .../bhyvexml2xmlout-vnc-wait-no.xml           | 44 +++++++++++++++++++
 .../bhyvexml2xmlout-vnc-wait.xml              | 44 +++++++++++++++++++
 tests/bhyvexml2xmltest.c                      |  2 +
 14 files changed, 192 insertions(+)
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc-wait-no.args
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc-wait-no.ldargs
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc-wait-no.xml
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc-wait.args
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc-wait.ldargs
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc-wait.xml
 create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-wait-no.xml
 create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-wait.xml

-- 
2.51.2
Re: [PATCH 0/2] bhyve: support VNC 'wait' attribute
Posted by Andrea Bolognani via Devel 2 months, 2 weeks ago
On Wed, Nov 19, 2025 at 06:54:24PM +0100, Roman Bogorodskiy wrote:
> Roman Bogorodskiy (2):
>   conf: introduce 'wait' attribute for VNC
>   bhyve: support VNC 'wait' attribute

Please add this new attribute to docs/formatdomain.rst, including the
fact that it's currently bhyve-only. I think mentioning it in the
release notes would be appropriate too.

-- 
Andrea Bolognani / Red Hat / Virtualization
Re: [PATCH 0/2] bhyve: support VNC 'wait' attribute
Posted by Roman Bogorodskiy 2 months, 2 weeks ago
  Andrea Bolognani wrote:

> On Wed, Nov 19, 2025 at 06:54:24PM +0100, Roman Bogorodskiy wrote:
> > Roman Bogorodskiy (2):
> >   conf: introduce 'wait' attribute for VNC
> >   bhyve: support VNC 'wait' attribute
> 
> Please add this new attribute to docs/formatdomain.rst, including the
> fact that it's currently bhyve-only. I think mentioning it in the
> release notes would be appropriate too.

Yes, I plan updating formatdomain.rst, drvbhyve.rst, and NEWS.rst either
later this week or early next week.

> -- 
> Andrea Bolognani / Red Hat / Virtualization
>
Re: [PATCH 0/2] bhyve: support VNC 'wait' attribute
Posted by Andrea Bolognani via Devel 2 months, 2 weeks ago
On Fri, Nov 21, 2025 at 01:16:50PM +0100, Roman Bogorodskiy wrote:
> > On Wed, Nov 19, 2025 at 06:54:24PM +0100, Roman Bogorodskiy wrote:
> > > Roman Bogorodskiy (2):
> > >   conf: introduce 'wait' attribute for VNC
> > >   bhyve: support VNC 'wait' attribute
> >
> > Please add this new attribute to docs/formatdomain.rst, including the
> > fact that it's currently bhyve-only. I think mentioning it in the
> > release notes would be appropriate too.
>
> Yes, I plan updating formatdomain.rst, drvbhyve.rst, and NEWS.rst either
> later this week or early next week.

No rush, as long as it makes it into the next release :)

Next time please include all that as part of the series itself
though. It just makes things easier for everyone. Thanks!

-- 
Andrea Bolognani / Red Hat / Virtualization