[PATCH RESEND] qemu: Remove redundant kvm group config in sysusers.d

Achill Gilgenast via Devel posted 1 patch 2 months, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20251115111917.121791-1-achill@achill.org
src/qemu/libvirt-qemu.sysusers.conf | 1 -
1 file changed, 1 deletion(-)
[PATCH RESEND] qemu: Remove redundant kvm group config in sysusers.d
Posted by Achill Gilgenast via Devel 2 months, 3 weeks ago
It's already defined by default in systemd:
https://github.com/systemd/systemd/blob/v257.6/sysusers.d/basic.conf.in#L32

Adding it again here in libvirt-qemu.sysusers.conf causes the following
warning by validating it with sd-sysuers:

	/usr/lib/sysusers.d/libvirt-qemu.conf:1: Conflict with earlier configuration for group 'kvm' in /usr/lib/sysusers.d/basic.conf:32, ignoring line.

I don't know if the GID is important, but from simple grepping around it
doesn't seem that way.

Signed-off-by: Achill Gilgenast <achill@achill.org>
---
 src/qemu/libvirt-qemu.sysusers.conf | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/qemu/libvirt-qemu.sysusers.conf b/src/qemu/libvirt-qemu.sysusers.conf
index 3189191e738a..05c35f94d814 100644
--- a/src/qemu/libvirt-qemu.sysusers.conf
+++ b/src/qemu/libvirt-qemu.sysusers.conf
@@ -1,4 +1,3 @@
-g kvm 36
 g qemu 107
 u qemu 107:qemu "qemu user" - -
 m qemu kvm
-- 
2.51.2
Re: [PATCH RESEND] qemu: Remove redundant kvm group config in sysusers.d
Posted by Daniel P. Berrangé via Devel 2 months, 2 weeks ago
On Sat, Nov 15, 2025 at 12:19:11PM +0100, Achill Gilgenast via Devel wrote:
> It's already defined by default in systemd:
> https://github.com/systemd/systemd/blob/v257.6/sysusers.d/basic.conf.in#L32
> 
> Adding it again here in libvirt-qemu.sysusers.conf causes the following
> warning by validating it with sd-sysuers:
> 
> 	/usr/lib/sysusers.d/libvirt-qemu.conf:1: Conflict with earlier configuration for group 'kvm' in /usr/lib/sysusers.d/basic.conf:32, ignoring line.
> 
> I don't know if the GID is important, but from simple grepping around it
> doesn't seem that way.

I'm changing this line to say:

    On Fedora/RHEL systemd is built with -Dkvm-gid=36 so there is no change
    in the allocated GID on these platforms. Other platforms have the same
    facility available to them if they wish to retain a fixed GID.


> 
> Signed-off-by: Achill Gilgenast <achill@achill.org>
> ---
>  src/qemu/libvirt-qemu.sysusers.conf | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

and pushed. Apologies for the delay to this trivial patch

> 
> diff --git a/src/qemu/libvirt-qemu.sysusers.conf b/src/qemu/libvirt-qemu.sysusers.conf
> index 3189191e738a..05c35f94d814 100644
> --- a/src/qemu/libvirt-qemu.sysusers.conf
> +++ b/src/qemu/libvirt-qemu.sysusers.conf
> @@ -1,4 +1,3 @@
> -g kvm 36
>  g qemu 107
>  u qemu 107:qemu "qemu user" - -
>  m qemu kvm
> -- 
> 2.51.2
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|