Greetings! I previously submitted this patch via GitLab [1] but was told to send
it here instead. Well, here it is. Including tests! :-)
The 1st patch contains the bugfix part:
It fixes a type mismatch (int/uint) preventing us from using the special
"never notify" value qemu recommends [2] for non-overcomitted VMs.
The 2nd patch contains the improvement:
While inspecting the bug I noticed that the default value for retries is
currently 0. That doesn't really make sense as we explicitly require it to
be >= 0xFFF (4095). This renders the retries attribute mandatory as
opposed to the xml schema definition which already defines it as optional.
This patch updates the default value to 0xFFFFFFFF (aka "never notify") and
makes it truly optional.
[1] https://gitlab.com/libvirt/libvirt/-/merge_requests/521
[2] https://www.qemu.org/docs/master/system/i386/hyperv.html#recommendations
Friedrich Oslage (2):
qemu: Fix hyperv spinlock retries count type mismatch
qemu: Update hyperv spinlock retries count default
src/conf/domain_conf.c | 9 +--
...-spinlocks-never-notify.x86_64-latest.args | 32 +++++++++++
...v-spinlocks-never-notify.x86_64-latest.xml | 56 +++++++++++++++++++
.../hyperv-spinlocks-never-notify.xml | 50 +++++++++++++++++
.../qemuxmlconfdata/hyperv.x86_64-latest.args | 2 +-
.../qemuxmlconfdata/hyperv.x86_64-latest.xml | 2 +-
tests/qemuxmlconfdata/hyperv.xml | 2 +-
tests/qemuxmlconftest.c | 1 +
8 files changed, 147 insertions(+), 7 deletions(-)
create mode 100644 tests/qemuxmlconfdata/hyperv-spinlocks-never-notify.x86_64-latest.args
create mode 100644 tests/qemuxmlconfdata/hyperv-spinlocks-never-notify.x86_64-latest.xml
create mode 100644 tests/qemuxmlconfdata/hyperv-spinlocks-never-notify.xml
--
2.51.0