[PATCH 0/5] CH: Add network interface hotplug support

Stefan Kober posted 5 patches 2 weeks, 5 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20251006151811.244611-1-stefan.kober@cyberus-technology.de
NEWS.rst            |   5 ++
src/ch/ch_alias.c   |  47 +++++++++++++
src/ch/ch_alias.h   |   3 +
src/ch/ch_hotplug.c |  83 ++++++++++++++++++++--
src/ch/ch_monitor.c |   5 +-
src/ch/ch_monitor.h |   1 -
src/ch/ch_process.c | 163 +++++++++++++++++++++++++-------------------
src/ch/ch_process.h |   8 +++
8 files changed, 234 insertions(+), 81 deletions(-)
[PATCH 0/5] CH: Add network interface hotplug support
Posted by Stefan Kober 2 weeks, 5 days ago
This patch set adds support for attaching and detaching network interfaces to Cloud Hypervisor domains at runtime.

Stefan Kober (5):
  ch: pass virCHDriver to chDomainAttachDeviceLice
  ch: add net device alias assignment
  ch: implement network device hot attach
  ch: implement network device hot detach
  NEWS: ch: announce network hotplug feature

 NEWS.rst            |   5 ++
 src/ch/ch_alias.c   |  47 +++++++++++++
 src/ch/ch_alias.h   |   3 +
 src/ch/ch_hotplug.c |  83 ++++++++++++++++++++--
 src/ch/ch_monitor.c |   5 +-
 src/ch/ch_monitor.h |   1 -
 src/ch/ch_process.c | 163 +++++++++++++++++++++++++-------------------
 src/ch/ch_process.h |   8 +++
 8 files changed, 234 insertions(+), 81 deletions(-)

-- 
2.51.0
Re: [PATCH 0/5] CH: Add network interface hotplug support
Posted by Michal Prívozník via Devel 2 weeks, 2 days ago
On 10/6/25 17:18, Stefan Kober wrote:
> This patch set adds support for attaching and detaching network interfaces to Cloud Hypervisor domains at runtime.
> 
> Stefan Kober (5):
>   ch: pass virCHDriver to chDomainAttachDeviceLice
>   ch: add net device alias assignment
>   ch: implement network device hot attach
>   ch: implement network device hot detach
>   NEWS: ch: announce network hotplug feature
> 
>  NEWS.rst            |   5 ++
>  src/ch/ch_alias.c   |  47 +++++++++++++
>  src/ch/ch_alias.h   |   3 +
>  src/ch/ch_hotplug.c |  83 ++++++++++++++++++++--
>  src/ch/ch_monitor.c |   5 +-
>  src/ch/ch_monitor.h |   1 -
>  src/ch/ch_process.c | 163 +++++++++++++++++++++++++-------------------
>  src/ch/ch_process.h |   8 +++
>  8 files changed, 234 insertions(+), 81 deletions(-)
> 

Just so that you know, I've seen these and did some initial review. They
are mostly okay, but I think we'll need some preparation work. I mean,
having functions talking to the CH socket in ch_process.c seems odd.

Alternatively, I can merge these (with very little changes - formatting
mostly) and then post cleanup patches that move things around. What do
you prefer?

Michal
Re: [PATCH 0/5] CH: Add network interface hotplug support
Posted by stefan.kober@cyberus-technology.de 2 weeks, 1 day ago
> Alternatively, I can merge these (with very little changes - formatting
> mostly) and then post cleanup patches that move things around. What do
> you prefer?

I am fine if you make small adjustment and put any larger changes on top. Hopefully, doing so can save us some back and forth and I will take a look at the end result to get a better feeling for how to structure things in the first place for next time.

Thanks for taking care :)