Fix sanlock without qemu (dejavu)

[PATCH v2 0/2] Fix sanlock without qemu (dejavu)

Daniel P. Berrangé via Devel posted 2 patches 2 weeks, 5 days ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20251006111732.3661169-1-berrange@redhat.com

libvirt.spec.in                 |  4 ++--
src/locking/libvirt_sanlock.aug |  1 +
src/locking/meson.build         | 16 ++++++++--------
3 files changed, 11 insertions(+), 10 deletions(-)

Expand all Fold all

[PATCH v2 0/2] Fix sanlock without qemu (dejavu)

Posted by Daniel P. Berrangé via Devel 2 weeks, 5 days ago

My previous RPM fix was wrong, as sanlock can actually be used with
libxl too. It is the meson rules that were wrong.

Daniel P. Berrangé (2):
  Revert "rpm: disable sanlock when QEMU is disabled"
  locking: use & install test_libvirt_sanlock.sug for both QEMU & LibXL

 libvirt.spec.in                 |  4 ++--
 src/locking/libvirt_sanlock.aug |  1 +
 src/locking/meson.build         | 16 ++++++++--------
 3 files changed, 11 insertions(+), 10 deletions(-)

-- 
2.50.1

Re: [PATCH v2 0/2] Fix sanlock without qemu (dejavu)

Posted by Martin Kletzander via Devel 2 weeks, 5 days ago

On Mon, Oct 06, 2025 at 12:17:30PM +0100, Daniel P. Berrangé via Devel wrote:
>My previous RPM fix was wrong, as sanlock can actually be used with
>libxl too. It is the meson rules that were wrong.
>

I could've foresee this, but both your previous fix and Cole's patch
together made sense... if blindly trusting our meson.build, which, it
turns out, is not only source of the perfect truth O:-)

>Daniel P. Berrangé (2):
>  Revert "rpm: disable sanlock when QEMU is disabled"
>  locking: use & install test_libvirt_sanlock.sug for both QEMU & LibXL
>

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

> libvirt.spec.in                 |  4 ++--
> src/locking/libvirt_sanlock.aug |  1 +
> src/locking/meson.build         | 16 ++++++++--------
> 3 files changed, 11 insertions(+), 10 deletions(-)
>
>-- 
>2.50.1
>