[PATCH] docs: domain: add watchdog notification support

Massimiliano Minella via B4 Relay via Devel posted 1 patch 4 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20251003-update._5Fwd._5Fdoc-v1-1-d96fa45fe994@se.com
docs/formatdomain.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] docs: domain: add watchdog notification support
Posted by Massimiliano Minella via B4 Relay via Devel 4 months, 1 week ago
From: Massimiliano Minella <massimiliano.minella@se.com>

Since v0.8.0 a watchdog notification is available under event ID
VIR_DOMAIN_EVENT_ID_WATCHDOG, update the documentation to remove the
previous limitation.

Signed-off-by: Massimiliano Minella <massimiliano.minella@se.com>
---
Remove limitation on notification support for watchdog.
---
 docs/formatdomain.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git docs/formatdomain.rst docs/formatdomain.rst
index f50dce477f..d70022a239 100644
--- docs/formatdomain.rst
+++ docs/formatdomain.rst
@@ -8350,8 +8350,8 @@ The watchdog device requires an additional driver and management daemon in the
 guest. Just enabling the watchdog in the libvirt configuration does not do
 anything useful on its own.
 
-Currently libvirt does not support notification when the watchdog fires. This
-feature is planned for a future version of libvirt.
+:since:`Since 0.8.0`, a notification is available when the watchdog fires, using
+the event ID ``VIR_DOMAIN_EVENT_ID_WATCHDOG``.
 
 Having multiple watchdogs is usually not something very common, but be aware
 that this might happen, for example, when an implicit watchdog device is added

---
base-commit: eb99bbaf2e5b1e91f4999c7a1ccc90d67dfbe471
change-id: 20251003-update_wd_doc-5aa9b43be09a

Best regards,
-- 
Massimiliano Minella <massimiliano.minella@se.com>
Re: [PATCH] docs: domain: add watchdog notification support
Posted by Ján Tomko via Devel 2 months, 3 weeks ago
On a Friday in 2025, Massimiliano Minella via B4 Relay via Devel wrote:
>From: Massimiliano Minella <massimiliano.minella@se.com>
>
>Since v0.8.0 a watchdog notification is available under event ID
>VIR_DOMAIN_EVENT_ID_WATCHDOG, update the documentation to remove the
>previous limitation.
>
>Signed-off-by: Massimiliano Minella <massimiliano.minella@se.com>
>---
>Remove limitation on notification support for watchdog.
>---
> docs/formatdomain.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git docs/formatdomain.rst docs/formatdomain.rst
>index f50dce477f..d70022a239 100644
>--- docs/formatdomain.rst
>+++ docs/formatdomain.rst
>@@ -8350,8 +8350,8 @@ The watchdog device requires an additional driver and management daemon in the
> guest. Just enabling the watchdog in the libvirt configuration does not do
> anything useful on its own.
>
>-Currently libvirt does not support notification when the watchdog fires. This
>-feature is planned for a future version of libvirt.
>+:since:`Since 0.8.0`, a notification is available when the watchdog fires, using
>+the event ID ``VIR_DOMAIN_EVENT_ID_WATCHDOG``.

Whoa, 0.8.0 was over 15 years ago.

>
> Having multiple watchdogs is usually not something very common, but be aware
> that this might happen, for example, when an implicit watchdog device is added
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>
and pushed now

Jano