examples/consolecallback.py: Use hex-encoding for `^]`

[PATCH libvirt-python v1] examples/consolecallback.py: Use hex-encoding for `^]`

Posted by Marc Hartmayer 2 days, 11 hours ago

Use hex encoding for ^] to prevent potential rendering issues in web browsers
when viewing the file on GitLab.

While at it, make the file an executable as a Shebang line is present.

Suggested-by: Dawson Rosell <dawson.rosell@ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
---
 examples/consolecallback.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 mode change 100644 => 100755 examples/consolecallback.py

diff --git a/examples/consolecallback.py b/examples/consolecallback.py
old mode 100644
new mode 100755
index a510fdf7e5d6..0f98d29e8069
--- a/examples/consolecallback.py
+++ b/examples/consolecallback.py
@@ -53,7 +53,7 @@ def check_console(console: Console) -> bool:
 
 def stdin_callback(watch: int, fd: int, events: int, console: Console) -> None:
     readbuf = os.read(fd, 1024)
-    if readbuf.startswith(b""):
+    if readbuf.startswith(b"\x1d"):
         console.run_console = False
         return
     if console.stream:

base-commit: 91b2f244c6434a85d9b4a0f7ec29140be707bb3d
-- 
2.43.0

Re: [PATCH libvirt-python v1] examples/consolecallback.py: Use hex-encoding for `^]`

Posted by Ján Tomko via Devel 2 days, 10 hours ago

On a Thursday in 2025, Marc Hartmayer wrote:
>Use hex encoding for ^] to prevent potential rendering issues in web browsers
>when viewing the file on GitLab.
>
>While at it, make the file an executable as a Shebang line is present.
>
>Suggested-by: Dawson Rosell <dawson.rosell@ibm.com>
>Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
>Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
>---
> examples/consolecallback.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> mode change 100644 => 100755 examples/consolecallback.py
>

Thanks, MR sent:
https://gitlab.com/libvirt/libvirt-python/-/merge_requests/178

Jano

Re: [PATCH libvirt-python v1] examples/consolecallback.py: Use hex-encoding for `^]`

Posted by Marc Hartmayer 2 days, 10 hours ago

On Thu, Oct 02, 2025 at 01:51 PM +0200, Ján Tomko <jtomko@redhat.com> wrote:
> On a Thursday in 2025, Marc Hartmayer wrote:
>>Use hex encoding for ^] to prevent potential rendering issues in web browsers
>>when viewing the file on GitLab.
>>
>>While at it, make the file an executable as a Shebang line is present.
>>
>>Suggested-by: Dawson Rosell <dawson.rosell@ibm.com>
>>Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
>>Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
>>---
>> examples/consolecallback.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> mode change 100644 => 100755 examples/consolecallback.py
>>
>
> Thanks, MR sent:
> https://gitlab.com/libvirt/libvirt-python/-/merge_requests/178

Thanks.

>
> Jano
-- 
Kind regards / Beste Grüße
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294