[v6] qemu: acpi-generic-initiator support

[PATCH 4/8] qemu: Validate acpi nodeset

Posted by Andrea Righi via Devel 5 months ago

Signed-off-by: Andrea Righi <arighi@nvidia.com>
---
 src/qemu/qemu_validate.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index adba3e4a89..c7ecb467a3 100644
--- a/src/qemu/qemu_validate.c
+++ b/src/qemu/qemu_validate.c
@@ -1717,6 +1717,14 @@ qemuValidateDomainDeviceInfo(const virDomainDeviceDef *dev,
         }
     }
 
+    if (info->acpiNodeset) {
+        if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_ACPI_GENERIC_INITIATOR)) {
+            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+                           _("ACPI nodeset is not supported with this QEMU"));
+            return -1;
+        }
+    }
+
     if (info->romenabled || info->rombar || info->romfile) {
         if (info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI &&
             info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE &&
-- 
2.51.0

Re: [PATCH 4/8] qemu: Validate acpi nodeset

Posted by Daniel P. Berrangé via Devel 5 months ago

On Sat, Sep 06, 2025 at 03:08:59PM +0200, Andrea Righi wrote:
> Signed-off-by: Andrea Righi <arighi@nvidia.com>
> ---
>  src/qemu/qemu_validate.c | 8 ++++++++
>  1 file changed, 8 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|