On 9/4/25 14:10, Stefan Kober wrote:
> This patchset adds the necessary functionality to support disk hotplugging in the CH driver.
>
> Some alias handling that can be extended to other device types is added, in order to allow detaching the devices via the Cloud Hypervisor API.
>
> Stefan Kober (13):
> ch: add ch_hotplug.{h,c} files to CH build
> ch: pass disk alias to CHV
> ch: add ch_alias.{c,h} for device alias handling
> ch: refactor virCHMonitorBuildDiskJson
> ch: add/use virCHMonitorPut function
> ch: add monitor disk attach logic
> ch: add disk attach helper functions
> ch: implement disk attach in public API
> ch: assign aliases in ProcessPrepareDomain
> ch: add virCHMonitorBuildKeyValueJson
> ch: add virCHMonitorRemoveDevice function
> ch: implement disk device detach in public API
> NEWS: announce disk hotplug support for ch
>
> NEWS.rst | 5 +
> po/POTFILES | 2 +
> src/ch/ch_alias.c | 62 +++++++++
> src/ch/ch_alias.h | 27 ++++
> src/ch/ch_driver.c | 86 ++++++++++++
> src/ch/ch_hotplug.c | 333 ++++++++++++++++++++++++++++++++++++++++++++
> src/ch/ch_hotplug.h | 33 +++++
> src/ch/ch_monitor.c | 131 ++++++++++++++---
> src/ch/ch_monitor.h | 7 +
> src/ch/ch_process.c | 4 +
> src/ch/meson.build | 4 +
> 11 files changed, 671 insertions(+), 23 deletions(-)
> create mode 100644 src/ch/ch_alias.c
> create mode 100644 src/ch/ch_alias.h
> create mode 100644 src/ch/ch_hotplug.c
> create mode 100644 src/ch/ch_hotplug.h
>
This looks way better than previous version. Thank you for working in my
suggestions. There are still some small problems, but I'll fix them
before merging.
Also, I'm moving some hunks between some patches AND I'm reordering some
patches too. For instance, patch 02/13 introduces a temporary regression
as it requires aliases to be assigned to disks, but that doesn't happen
until patch 09/13. If these are reordered then no regression occurs.
Anyway, good job! What should be done in a follow up series is to emit
events on device attach/detach. Management apps will certainly value that.
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
and merged.
Michal