A couple improvements when auto-adding PCI controllers

[PATCH 0/3] A couple improvements when auto-adding PCI controllers

Posted by Laine Stump via Devel 5 months, 2 weeks ago

The 1st patch fixes a tiny omission from a feature added several years
ago, which slightly improves the error message when you attempt to add
a pcie-to-pci-bridge controller to a domain that has no PCIe bus. The
2nd improves that error message a bit more, along with improving some
comments in the code.

The 3rd eliminates said error message completely when you're adding a
pcie-to-pci-bridge controller to a domain that *does* support PCIe,
but doesn't currently have an open pcie-root-port to plug in the
pcie-to-pci-bridge (by auto-adding another pcie-root-port).

The impetus for these was https://issues.redhat.com/browse/RHEL-62032

Laine Stump (3):
  conf: add forgotten clause to
    virDomainPCIControllerConectTypeToModel()
  conf: improve error message when a PCI controller can't be auto-added
  conf: auto-add a pcie-root-port when needed while plugging in
    pcie-to-pci-bridge

 src/conf/domain_addr.c                        | 43 +++++++++++++++----
 .../pcie-root-port-too-many.x86_64-latest.err |  2 +-
 2 files changed, 35 insertions(+), 10 deletions(-)

-- 
2.51.0

Re: [PATCH 0/3] A couple improvements when auto-adding PCI controllers

Posted by Ján Tomko via Devel 5 months ago

On a Wednesday in 2025, Laine Stump via Devel wrote:
>The 1st patch fixes a tiny omission from a feature added several years
>ago, which slightly improves the error message when you attempt to add
>a pcie-to-pci-bridge controller to a domain that has no PCIe bus. The
>2nd improves that error message a bit more, along with improving some
>comments in the code.
>
>The 3rd eliminates said error message completely when you're adding a
>pcie-to-pci-bridge controller to a domain that *does* support PCIe,
>but doesn't currently have an open pcie-root-port to plug in the
>pcie-to-pci-bridge (by auto-adding another pcie-root-port).
>
>The impetus for these was https://issues.redhat.com/browse/RHEL-62032
>
>Laine Stump (3):
>  conf: add forgotten clause to
>    virDomainPCIControllerConectTypeToModel()
>  conf: improve error message when a PCI controller can't be auto-added
>  conf: auto-add a pcie-root-port when needed while plugging in
>    pcie-to-pci-bridge
>
> src/conf/domain_addr.c                        | 43 +++++++++++++++----
> .../pcie-root-port-too-many.x86_64-latest.err |  2 +-
> 2 files changed, 35 insertions(+), 10 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano