[PATCH 4/4] qemu_cgroup: add /dev/mshv to default devices

Praveen K Paladugu posted 4 patches 1 month ago
There is a newer version of this series
[PATCH 4/4] qemu_cgroup: add /dev/mshv to default devices
Posted by Praveen K Paladugu 1 month ago
From: Praveen K Paladugu <prapal@linux.microsoft.com>

Add /dev/mshv to default set of devices to pass to domain cgroup.

Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
Signed-off-by: Praveen K Paladugu <praveenkpaladugu@gmail.com>
---
 src/qemu/qemu_cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index f10976c2b0..b9b68d38d5 100644
--- a/src/qemu/qemu_cgroup.c
+++ b/src/qemu/qemu_cgroup.c
@@ -41,7 +41,7 @@ VIR_LOG_INIT("qemu.qemu_cgroup");
 const char *const defaultDeviceACL[] = {
     "/dev/null", "/dev/full", "/dev/zero",
     "/dev/random", "/dev/urandom",
-    "/dev/ptmx", "/dev/kvm",
+    "/dev/ptmx", "/dev/kvm", "/dev/mshv",
     "/dev/userfaultfd",
     NULL,
 };
-- 
2.50.1
Re: [PATCH 4/4] qemu_cgroup: add /dev/mshv to default devices
Posted by Daniel P. Berrangé via Devel 2 weeks, 4 days ago
On Thu, Aug 07, 2025 at 03:48:43PM -0500, Praveen K Paladugu wrote:
> From: Praveen K Paladugu <prapal@linux.microsoft.com>
> 
> Add /dev/mshv to default set of devices to pass to domain cgroup.
> 
> Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
> Signed-off-by: Praveen K Paladugu <praveenkpaladugu@gmail.com>
> ---
>  src/qemu/qemu_cgroup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
> index f10976c2b0..b9b68d38d5 100644
> --- a/src/qemu/qemu_cgroup.c
> +++ b/src/qemu/qemu_cgroup.c
> @@ -41,7 +41,7 @@ VIR_LOG_INIT("qemu.qemu_cgroup");
>  const char *const defaultDeviceACL[] = {
>      "/dev/null", "/dev/full", "/dev/zero",
>      "/dev/random", "/dev/urandom",
> -    "/dev/ptmx", "/dev/kvm",
> +    "/dev/ptmx", "/dev/kvm", "/dev/mshv",

Oh should update src/qemu/qemu.conf.in and src/qemu/test_libvirtd_qemu.aug.in
to match this too.

>      "/dev/userfaultfd",
>      NULL,
>  };
> -- 
> 2.50.1
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Re: [PATCH 4/4] qemu_cgroup: add /dev/mshv to default devices
Posted by Daniel P. Berrangé via Devel 2 weeks, 4 days ago
On Thu, Aug 07, 2025 at 03:48:43PM -0500, Praveen K Paladugu wrote:
> From: Praveen K Paladugu <prapal@linux.microsoft.com>
> 
> Add /dev/mshv to default set of devices to pass to domain cgroup.
> 
> Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
> Signed-off-by: Praveen K Paladugu <praveenkpaladugu@gmail.com>
> ---
>  src/qemu/qemu_cgroup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|