[PATCH 3/4] qemu: use mshv accel for hyperv domains

Praveen K Paladugu posted 4 patches 1 month ago
There is a newer version of this series
[PATCH 3/4] qemu: use mshv accel for hyperv domains
Posted by Praveen K Paladugu 1 month ago
From: Praveen K Paladugu <prapal@linux.microsoft.com>

Add mshv acceleration (-accel mshv) flag to hyperv domains

Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
Signed-off-by: Praveen K Paladugu <praveenkpaladugu@gmail.com>
---
 src/qemu/qemu_command.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 4e4f1e87eb..3aafacb14d 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -7321,6 +7321,9 @@ qemuBuildAccelCommandLine(virCommand *cmd,
         virBufferAddLit(&buf, "hvf");
         break;
 
+    case VIR_DOMAIN_VIRT_HYPERV:
+        virBufferAddLit(&buf, "mshv");
+        break;
     case VIR_DOMAIN_VIRT_KQEMU:
     case VIR_DOMAIN_VIRT_XEN:
     case VIR_DOMAIN_VIRT_LXC:
@@ -7328,7 +7331,6 @@ qemuBuildAccelCommandLine(virCommand *cmd,
     case VIR_DOMAIN_VIRT_OPENVZ:
     case VIR_DOMAIN_VIRT_TEST:
     case VIR_DOMAIN_VIRT_VMWARE:
-    case VIR_DOMAIN_VIRT_HYPERV:
     case VIR_DOMAIN_VIRT_VBOX:
     case VIR_DOMAIN_VIRT_PHYP:
     case VIR_DOMAIN_VIRT_PARALLELS:
-- 
2.50.1
Re: [PATCH 3/4] qemu: use mshv accel for hyperv domains
Posted by Daniel P. Berrangé via Devel 2 weeks, 4 days ago
On Thu, Aug 07, 2025 at 03:48:42PM -0500, Praveen K Paladugu wrote:
> From: Praveen K Paladugu <prapal@linux.microsoft.com>
> 
> Add mshv acceleration (-accel mshv) flag to hyperv domains
> 
> Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
> Signed-off-by: Praveen K Paladugu <praveenkpaladugu@gmail.com>
> ---
>  src/qemu/qemu_command.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


nb, this patch  & the next ought to be /before/ patch 2, as the
patch 2 changes will unlock the ability for users to specify
type=hyperv in XML which will then be broken until this patch &
next patch are applied.

> 
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index 4e4f1e87eb..3aafacb14d 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -7321,6 +7321,9 @@ qemuBuildAccelCommandLine(virCommand *cmd,
>          virBufferAddLit(&buf, "hvf");
>          break;
>  
> +    case VIR_DOMAIN_VIRT_HYPERV:
> +        virBufferAddLit(&buf, "mshv");
> +        break;
>      case VIR_DOMAIN_VIRT_KQEMU:
>      case VIR_DOMAIN_VIRT_XEN:
>      case VIR_DOMAIN_VIRT_LXC:
> @@ -7328,7 +7331,6 @@ qemuBuildAccelCommandLine(virCommand *cmd,
>      case VIR_DOMAIN_VIRT_OPENVZ:
>      case VIR_DOMAIN_VIRT_TEST:
>      case VIR_DOMAIN_VIRT_VMWARE:
> -    case VIR_DOMAIN_VIRT_HYPERV:
>      case VIR_DOMAIN_VIRT_VBOX:
>      case VIR_DOMAIN_VIRT_PHYP:
>      case VIR_DOMAIN_VIRT_PARALLELS:
> -- 
> 2.50.1
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|