This series adds support for a new 'edid' attribute to the video model to control
whether the EDID is visible to the guest. If the 'edid' attribute is unspecified
then it is not generated in the domain XML, so the underlying virtualisation
platform will continue to use its default.

The 'edid' attribute is only valid for the vga, boch and virtio display models
and is currently only implemented for the QEMU driver.

Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>

v3
- Rebase onto master
- Use backtacks for video models and values in docs/formatdomain.rst
- Add edid attribute check in virDomainVideoDefCheckABIStability()
- Remove disks from test XML files
- Move video model edid attribute tests into the same section used by
  the existing video model tests

v2
- Rebase onto master
- Remove 2nd sentence from v1 patch 1 commit message
- Remove unnecessary video->type check in qemu_command.c
- Add patch 2 containing qemuxmlconftest test cases


Mark Cave-Ayland (2):
  conf: add support for 'edid' attribute to video model
  tests/qemuxmlconfdata: add tests for video model 'edid' attribute

 docs/formatdomain.rst                         |  8 ++++
 src/conf/domain_conf.c                        | 13 ++++++
 src/conf/domain_conf.h                        |  1 +
 src/conf/domain_validate.c                    | 11 +++++
 src/conf/schemas/domaincommon.rng             |  5 +++
 src/qemu/qemu_command.c                       |  3 ++
 .../video-bochs-edid-none.x86_64-latest.args  | 34 +++++++++++++++
 .../video-bochs-edid-none.x86_64-latest.xml   | 41 +++++++++++++++++++
 .../qemuxmlconfdata/video-bochs-edid-none.xml | 30 ++++++++++++++
 .../video-bochs-edid-off.x86_64-latest.args   | 34 +++++++++++++++
 .../video-bochs-edid-off.x86_64-latest.xml    | 41 +++++++++++++++++++
 .../qemuxmlconfdata/video-bochs-edid-off.xml  | 30 ++++++++++++++
 .../video-bochs-edid-on.x86_64-latest.args    | 34 +++++++++++++++
 .../video-bochs-edid-on.x86_64-latest.xml     | 41 +++++++++++++++++++
 tests/qemuxmlconfdata/video-bochs-edid-on.xml | 30 ++++++++++++++
 .../video-qxl-edid-off-fail.x86_64-latest.err |  1 +
 .../video-qxl-edid-off-fail.xml               | 23 +++++++++++
 .../video-qxl-edid-on-fail.x86_64-latest.err  |  1 +
 .../video-qxl-edid-on-fail.xml                | 23 +++++++++++
 .../video-vga-edid-none.x86_64-latest.args    | 34 +++++++++++++++
 .../video-vga-edid-none.x86_64-latest.xml     | 41 +++++++++++++++++++
 tests/qemuxmlconfdata/video-vga-edid-none.xml | 30 ++++++++++++++
 .../video-vga-edid-off.x86_64-latest.args     | 34 +++++++++++++++
 .../video-vga-edid-off.x86_64-latest.xml      | 41 +++++++++++++++++++
 tests/qemuxmlconfdata/video-vga-edid-off.xml  | 30 ++++++++++++++
 .../video-vga-edid-on.x86_64-latest.args      | 34 +++++++++++++++
 .../video-vga-edid-on.x86_64-latest.xml       | 41 +++++++++++++++++++
 tests/qemuxmlconfdata/video-vga-edid-on.xml   | 30 ++++++++++++++
 .../video-virtio-edid-none.x86_64-latest.args | 34 +++++++++++++++
 .../video-virtio-edid-none.x86_64-latest.xml  | 41 +++++++++++++++++++
 .../video-virtio-edid-none.xml                | 30 ++++++++++++++
 .../video-virtio-edid-off.x86_64-latest.args  | 34 +++++++++++++++
 .../video-virtio-edid-off.x86_64-latest.xml   | 41 +++++++++++++++++++
 .../qemuxmlconfdata/video-virtio-edid-off.xml | 30 ++++++++++++++
 .../video-virtio-edid-on.x86_64-latest.args   | 34 +++++++++++++++
 .../video-virtio-edid-on.x86_64-latest.xml    | 41 +++++++++++++++++++
 .../qemuxmlconfdata/video-virtio-edid-on.xml  | 30 ++++++++++++++
 tests/qemuxmlconftest.c                       | 11 +++++
 38 files changed, 1045 insertions(+)
 create mode 100644 tests/qemuxmlconfdata/video-bochs-edid-none.x86_64-latest.args
 create mode 100644 tests/qemuxmlconfdata/video-bochs-edid-none.x86_64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/video-bochs-edid-none.xml
 create mode 100644 tests/qemuxmlconfdata/video-bochs-edid-off.x86_64-latest.args
 create mode 100644 tests/qemuxmlconfdata/video-bochs-edid-off.x86_64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/video-bochs-edid-off.xml
 create mode 100644 tests/qemuxmlconfdata/video-bochs-edid-on.x86_64-latest.args
 create mode 100644 tests/qemuxmlconfdata/video-bochs-edid-on.x86_64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/video-bochs-edid-on.xml
 create mode 100644 tests/qemuxmlconfdata/video-qxl-edid-off-fail.x86_64-latest.err
 create mode 100644 tests/qemuxmlconfdata/video-qxl-edid-off-fail.xml
 create mode 100644 tests/qemuxmlconfdata/video-qxl-edid-on-fail.x86_64-latest.err
 create mode 100644 tests/qemuxmlconfdata/video-qxl-edid-on-fail.xml
 create mode 100644 tests/qemuxmlconfdata/video-vga-edid-none.x86_64-latest.args
 create mode 100644 tests/qemuxmlconfdata/video-vga-edid-none.x86_64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/video-vga-edid-none.xml
 create mode 100644 tests/qemuxmlconfdata/video-vga-edid-off.x86_64-latest.args
 create mode 100644 tests/qemuxmlconfdata/video-vga-edid-off.x86_64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/video-vga-edid-off.xml
 create mode 100644 tests/qemuxmlconfdata/video-vga-edid-on.x86_64-latest.args
 create mode 100644 tests/qemuxmlconfdata/video-vga-edid-on.x86_64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/video-vga-edid-on.xml
 create mode 100644 tests/qemuxmlconfdata/video-virtio-edid-none.x86_64-latest.args
 create mode 100644 tests/qemuxmlconfdata/video-virtio-edid-none.x86_64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/video-virtio-edid-none.xml
 create mode 100644 tests/qemuxmlconfdata/video-virtio-edid-off.x86_64-latest.args
 create mode 100644 tests/qemuxmlconfdata/video-virtio-edid-off.x86_64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/video-virtio-edid-off.xml
 create mode 100644 tests/qemuxmlconfdata/video-virtio-edid-on.x86_64-latest.args
 create mode 100644 tests/qemuxmlconfdata/video-virtio-edid-on.x86_64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/video-virtio-edid-on.xml

-- 
2.43.0

On Thu, Aug 07, 2025 at 12:05:08 +0100, Mark Cave-Ayland wrote:
> This series adds support for a new 'edid' attribute to the video model to control
> whether the EDID is visible to the guest. If the 'edid' attribute is unspecified
> then it is not generated in the domain XML, so the underlying virtualisation
> platform will continue to use its default.
> 
> The 'edid' attribute is only valid for the vga, boch and virtio display models
> and is currently only implemented for the QEMU driver.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> 
> v3
> - Rebase onto master
> - Use backtacks for video models and values in docs/formatdomain.rst
> - Add edid attribute check in virDomainVideoDefCheckABIStability()
> - Remove disks from test XML files
> - Move video model edid attribute tests into the same section used by
>   the existing video model tests
> 
> v2
> - Rebase onto master
> - Remove 2nd sentence from v1 patch 1 commit message
> - Remove unnecessary video->type check in qemu_command.c
> - Add patch 2 containing qemuxmlconftest test cases

Sorry for taking longer to notice this series, but the mailing list was
broken for some time.

Series:

Reviewed-by: Peter Krempa <pkrempa@redhat.com>

and pushed.

On 14/08/2025 11:49, Peter Krempa wrote:

> On Thu, Aug 07, 2025 at 12:05:08 +0100, Mark Cave-Ayland wrote:
>> This series adds support for a new 'edid' attribute to the video model to control
>> whether the EDID is visible to the guest. If the 'edid' attribute is unspecified
>> then it is not generated in the domain XML, so the underlying virtualisation
>> platform will continue to use its default.
>>
>> The 'edid' attribute is only valid for the vga, boch and virtio display models
>> and is currently only implemented for the QEMU driver.
>>
>> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
>>
>> v3
>> - Rebase onto master
>> - Use backtacks for video models and values in docs/formatdomain.rst
>> - Add edid attribute check in virDomainVideoDefCheckABIStability()
>> - Remove disks from test XML files
>> - Move video model edid attribute tests into the same section used by
>>    the existing video model tests
>>
>> v2
>> - Rebase onto master
>> - Remove 2nd sentence from v1 patch 1 commit message
>> - Remove unnecessary video->type check in qemu_command.c
>> - Add patch 2 containing qemuxmlconftest test cases
> 
> Sorry for taking longer to notice this series, but the mailing list was
> broken for some time.
> 
> Series:
> 
> Reviewed-by: Peter Krempa <pkrempa@redhat.com>
> 
> and pushed.

No worries, I completely understand it has been a difficult week without 
the mailing lists/archives working. Thanks once again for the review 
feedback, greatly appreciated.


ATB,

Mark.