[v2] Some parsing functions refactor

[PATCH v2 0/4] Some parsing functions refactor

Kirill Shchetiniuk via Devel posted 4 patches 1 month, 2 weeks ago

Diff against v1
Download series mbox

Failed in applying to current master (apply log)

src/conf/domain_conf.c               |  16 +---
src/conf/netdev_vport_profile_conf.c | 112 +++++++++++----------------
src/qemu/qemu_domain.c               |  16 +---
src/util/virsecret.c                 |  19 ++---
4 files changed, 55 insertions(+), 108 deletions(-)

Expand all Fold all

[PATCH v2 0/4] Some parsing functions refactor

Posted by Kirill Shchetiniuk via Devel 1 month, 2 weeks ago

This patch series is supposed to refactor the existing logic of
some parsing functions, changing the previous approach of getting
the string fisrt and then parsing the string itself. Now the
parsing logic is implemented by using the appropriate virXMLProp*
functions.

Changelog fromm v1:

1. 'ret' temp value is now 'rc'
2. code style fixes
3. 'id' param is now parsed as not mandatory


Kirill Shchetiniuk (4):
  conf: virNetDevVPortProfileParse refactor
  util: virSecretLookupParseSecret refactor
  conf: virDomainChrDefParseTargetXML refactor
  qemu: qemuDomainObjPrivateXMLParseVcpu refactor

 src/conf/domain_conf.c               |  16 +---
 src/conf/netdev_vport_profile_conf.c | 112 +++++++++++----------------
 src/qemu/qemu_domain.c               |  16 +---
 src/util/virsecret.c                 |  19 ++---
 4 files changed, 55 insertions(+), 108 deletions(-)

--
2.49.0

Re: [PATCH v2 0/4] Some parsing functions refactor

Posted by Michal Prívozník via Devel 1 month, 2 weeks ago

On 7/22/25 17:12, Kirill Shchetiniuk via Devel wrote:
> This patch series is supposed to refactor the existing logic of
> some parsing functions, changing the previous approach of getting
> the string fisrt and then parsing the string itself. Now the
> parsing logic is implemented by using the appropriate virXMLProp*
> functions.
> 
> Changelog fromm v1:
> 
> 1. 'ret' temp value is now 'rc'
> 2. code style fixes
> 3. 'id' param is now parsed as not mandatory
> 
> 
> Kirill Shchetiniuk (4):
>   conf: virNetDevVPortProfileParse refactor
>   util: virSecretLookupParseSecret refactor
>   conf: virDomainChrDefParseTargetXML refactor
>   qemu: qemuDomainObjPrivateXMLParseVcpu refactor
> 
>  src/conf/domain_conf.c               |  16 +---
>  src/conf/netdev_vport_profile_conf.c | 112 +++++++++++----------------
>  src/qemu/qemu_domain.c               |  16 +---
>  src/util/virsecret.c                 |  19 ++---
>  4 files changed, 55 insertions(+), 108 deletions(-)
> 
> --
> 2.49.0
> 

I'm fixing all the small nits I've raised and merging.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal