Changes since v1:

I misunderstood semantics of the 'mode' attribute of the <source>
element, and used 'connect' while I should have used 'bind', because
bhyve listens on the TCP socket and client connects to using using
netcat (or any other similar tool). Now it's using the 'bind' value.

Other changes: added validation to bhyve_domain.c, and unified error
messages used in bhyve_command.c and bhyve_domain.c

Roman Bogorodskiy (5):
  bhyve: support serial type 'tcp'
  bhyve: increase number of supported consoles to 4
  docs: drvbhyve: document TCP console support
  bhyve: validate serial devices validation
  bhyve: sync error messages

 docs/drvbhyve.rst                             | 19 ++++++
 src/bhyve/bhyve_capabilities.c                |  3 +-
 src/bhyve/bhyve_command.c                     | 42 +++++++++-----
 src/bhyve/bhyve_domain.c                      | 27 +++++++++
 .../bhyvexml2argv-4-consoles.args             | 15 +++++
 .../bhyvexml2argv-4-consoles.ldargs           |  4 ++
 .../bhyvexml2argv-4-consoles.xml              | 35 +++++++++++
 .../bhyvexml2argv-serial-invalid-port.args    | 12 ++++
 .../bhyvexml2argv-serial-invalid-port.ldargs  |  4 ++
 .../bhyvexml2argv-serial-invalid-port.xml     | 28 +++++++++
 .../bhyvexml2argv-serial-tcp.args             | 12 ++++
 .../bhyvexml2argv-serial-tcp.ldargs           |  4 ++
 .../bhyvexml2argv-serial-tcp.xml              | 27 +++++++++
 tests/bhyvexml2argvtest.c                     |  3 +
 .../bhyvexml2xmlout-4-consoles.xml            | 58 +++++++++++++++++++
 .../bhyvexml2xmlout-serial-tcp.xml            | 46 +++++++++++++++
 tests/bhyvexml2xmltest.c                      |  2 +
 tests/domaincapsdata/bhyve_basic.x86_64.xml   |  1 +
 tests/domaincapsdata/bhyve_fbuf.x86_64.xml    |  1 +
 tests/domaincapsdata/bhyve_uefi.x86_64.xml    |  1 +
 20 files changed, 328 insertions(+), 16 deletions(-)
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-4-consoles.args
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-4-consoles.ldargs
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-4-consoles.xml
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-serial-invalid-port.args
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-serial-invalid-port.ldargs
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-serial-invalid-port.xml
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-serial-tcp.args
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-serial-tcp.ldargs
 create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-serial-tcp.xml
 create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-4-consoles.xml
 create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-serial-tcp.xml

-- 
2.49.0