On Tue, Jun 03, 2025 at 03:53:53PM +0200, Ján Tomko wrote:
> On a Monday in 2025, Kirill Shchetiniuk via Devel wrote:
> > This series is supposed to refactor the existing parse logic by
> > using the proper utility function and some parameters type change.
> >
> > 1. VNC graphics pasing were refactored to use the vitXMLProp* utility functions.
> > 'autoport' and 'websocketGenerated' remain their bool type, as this structure
> > members can be also modified later and not only determined by the initial XML
> > definition.
> >
> > 2. RDP graphics refactored same as VNC graphics, exept that 'multiUser' and
> > 'replaceUser' types changed from bool to tristate, as parameters determined
> > only by the initial XML.
> >
> > 3. SDL graphics fullscreen option type changed from bool to tristate, to avoid
> > unnecessary type convertions.
> >
> > 4. desktop fullscreen option is removed as it was never used.
> >
> > Kirill Shchetiniuk (4):
> > conf: VNC graphics parse refactor
> > conf: SDL fullscreen option refactor
> > conf: RDP graphics parse refactor
> > conf: desktop graphics remove unused option
> >
> > docs/formatdomain.rst | 5 +-
> > src/conf/domain_conf.c | 125 ++++++++++++++----------------
> > src/conf/domain_conf.h | 7 +-
> > src/conf/schemas/domaincommon.rng | 5 --
> > src/qemu/qemu_command.c | 2 +-
> > src/qemu/qemu_process.c | 4 +-
> > src/qemu/qemu_validate.c | 4 +-
> > src/vbox/vbox_common.c | 8 +-
> > 8 files changed, 71 insertions(+), 89 deletions(-)
> >
> > --
> > 2.49.0
> >
>
> I am unable to apply these patches:
>
> Applying: conf: VNC graphics parse refactor
> error: patch failed: src/conf/domain_conf.c:11815
> error: src/conf/domain_conf.c: patch does not apply
> Patch failed at 0001 conf: VNC graphics parse refactor
>
> Probably some server mangled them on the way. Not sure what magic
> setting is needed for git-format-patch to get them through unmangled.
> Patches from others using US-ASCII and quoted-printable encoding apply
> for me.
>
> Do you have this applied somewhere on gitlab or similar service?
>
> Jano
Hi Jano,
you are right, some problem occured, I have sent the second version
here https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/SN7PQ3XTLUJYLSRYW2YPXNAWRB7UXNQF/
for me it is working now.
Kirill