[PATCH v4 0/2] Fix virtio console port assignment issue

Aaron M. Brown posted 2 patches 3 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20250523012735.89278-1-aaronmbr@linux.ibm.com
There is a newer version of this series
src/conf/domain_addr.c | 26 ++++++++++++++++----------
1 file changed, 16 insertions(+), 10 deletions(-)
[PATCH v4 0/2] Fix virtio console port assignment issue
Posted by Aaron M. Brown 3 months, 2 weeks ago
Changelog:
---
v4:
 - Update commit messages
---
v3:
 - Added Reviewed-By
 - Included CI Results Link
---
v2:
 - Split patch into two commits
 - Added fixes tag
---


This libvirt patch does the following:
1. fixes an issue with virtio console device port assignment on vioserial buses
2. updates console port reservation comment and changes the allowZero variable to allowPortZero for clarity

Currently in libvirt, a virtio console device cannot be assigned a port number greater than zero on a vioserial bus. This leads to port collision errors when adding more than 1 virtio console device on a single vioserial bus.

After applying this patch, one can add multiple console ports under a single vioserial bus.

Here is a link to CI results for this series: https://gitlab.com/aaronbmalik/libvirt/-/pipelines/1832324065

Aaron M. Brown (2):
  virDomainVirtioSerialAddrAssign: Fix virtio console port assignment on
    vioserial bus
  domain_addr.c: Update console port reservation comment and allowZero
    variable for clarity

 src/conf/domain_addr.c | 26 ++++++++++++++++----------
 1 file changed, 16 insertions(+), 10 deletions(-)

--
2.39.5 (Apple Git-154)
Re: [PATCH v4 0/2] Fix virtio console port assignment issue
Posted by Peter Krempa via Devel 3 months, 2 weeks ago
On Thu, May 22, 2025 at 21:27:33 -0400, Aaron M. Brown wrote:
> Changelog:
> ---
> v4:
>  - Update commit messages
> ---
> v3:
>  - Added Reviewed-By
>  - Included CI Results Link
> ---
> v2:
>  - Split patch into two commits
>  - Added fixes tag
> ---

Hi,

I didn't find any of the 3 previous versions in the archives.
Re: [PATCH v4 0/2] Fix virtio console port assignment issue
Posted by Aaron Brown 3 months ago
My apologies Peter, this is my first time upstream. The first two versions were internally reviewed