Add a pcihole64 test for the aarch64 virt machine that verifies the
value is propagated to the highmem-mmio-size virt machine parameter.

Signed-off-by: Matthew R. Ochs <mochs@nvidia.com>
---
 .../pcihole64-virt.aarch64-latest.args        | 31 +++++++++++++++++++
 .../pcihole64-virt.aarch64-latest.xml         | 29 +++++++++++++++++
 tests/qemuxmlconfdata/pcihole64-virt.xml      | 17 ++++++++++
 tests/qemuxmlconftest.c                       |  1 +
 4 files changed, 78 insertions(+)
 create mode 100644 tests/qemuxmlconfdata/pcihole64-virt.aarch64-latest.args
 create mode 100644 tests/qemuxmlconfdata/pcihole64-virt.aarch64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/pcihole64-virt.xml

diff --git a/tests/qemuxmlconfdata/pcihole64-virt.aarch64-latest.args b/tests/qemuxmlconfdata/pcihole64-virt.aarch64-latest.args
new file mode 100644
index 000000000000..d2df31ed868e
--- /dev/null
+++ b/tests/qemuxmlconfdata/pcihole64-virt.aarch64-latest.args
@@ -0,0 +1,31 @@
+LC_ALL=C \
+PATH=/bin \
+HOME=/var/lib/libvirt/qemu/domain--1-foo \
+USER=test \
+LOGNAME=test \
+XDG_DATA_HOME=/var/lib/libvirt/qemu/domain--1-foo/.local/share \
+XDG_CACHE_HOME=/var/lib/libvirt/qemu/domain--1-foo/.cache \
+XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-foo/.config \
+/usr/bin/qemu-system-aarch64 \
+-name guest=foo,debug-threads=on \
+-S \
+-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-foo/master-key.aes"}' \
+-machine virt,usb=off,gic-version=2,dump-guest-core=off,memory-backend=mach-virt.ram,acpi=off,highmem-mmio-size=536870912K \
+-accel tcg \
+-cpu cortex-a15 \
+-m size=1048576k \
+-object '{"qom-type":"memory-backend-ram","id":"mach-virt.ram","size":1073741824}' \
+-overcommit mem-lock=off \
+-smp 1,sockets=1,cores=1,threads=1 \
+-uuid 6ba7b810-9dad-11d1-80b4-00c04fd430c8 \
+-display none \
+-no-user-config \
+-nodefaults \
+-chardev socket,id=charmonitor,fd=1729,server=on,wait=off \
+-mon chardev=charmonitor,id=monitor,mode=control \
+-rtc base=utc \
+-no-shutdown \
+-boot strict=on \
+-audiodev '{"id":"audio1","driver":"none"}' \
+-sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \
+-msg timestamp=on
diff --git a/tests/qemuxmlconfdata/pcihole64-virt.aarch64-latest.xml b/tests/qemuxmlconfdata/pcihole64-virt.aarch64-latest.xml
new file mode 100644
index 000000000000..1fb38b429e9f
--- /dev/null
+++ b/tests/qemuxmlconfdata/pcihole64-virt.aarch64-latest.xml
@@ -0,0 +1,29 @@
+<domain type='qemu'>
+  <name>foo</name>
+  <uuid>6ba7b810-9dad-11d1-80b4-00c04fd430c8</uuid>
+  <memory unit='KiB'>1048576</memory>
+  <currentMemory unit='KiB'>1048576</currentMemory>
+  <vcpu placement='static'>1</vcpu>
+  <os>
+    <type arch='aarch64' machine='virt'>hvm</type>
+    <boot dev='hd'/>
+  </os>
+  <features>
+    <gic version='2'/>
+  </features>
+  <cpu mode='custom' match='exact' check='none'>
+    <model fallback='forbid'>cortex-a15</model>
+  </cpu>
+  <clock offset='utc'/>
+  <on_poweroff>destroy</on_poweroff>
+  <on_reboot>restart</on_reboot>
+  <on_crash>destroy</on_crash>
+  <devices>
+    <emulator>/usr/bin/qemu-system-aarch64</emulator>
+    <controller type='pci' index='0' model='pcie-root'>
+      <pcihole64 unit='KiB'>536870912</pcihole64>
+    </controller>
+    <audio id='1' type='none'/>
+    <memballoon model='none'/>
+  </devices>
+</domain>
diff --git a/tests/qemuxmlconfdata/pcihole64-virt.xml b/tests/qemuxmlconfdata/pcihole64-virt.xml
new file mode 100644
index 000000000000..00bb51ab0e9a
--- /dev/null
+++ b/tests/qemuxmlconfdata/pcihole64-virt.xml
@@ -0,0 +1,17 @@
+<domain type='qemu'>
+  <name>foo</name>
+  <uuid>6ba7b810-9dad-11d1-80b4-00c04fd430c8</uuid>
+  <memory unit='KiB'>1048576</memory>
+  <currentMemory unit='KiB'>1048576</currentMemory>
+  <vcpu placement='static'>1</vcpu>
+  <os>
+    <type arch='aarch64' machine='virt'>hvm</type>
+  </os>
+  <devices>
+    <emulator>/usr/bin/qemu-system-aarch64</emulator>
+    <controller type='pci' index='0' model='pcie-root'>
+      <pcihole64 unit='GiB'>512</pcihole64>
+    </controller>
+    <memballoon model='none'/>
+  </devices>
+</domain>
diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c
index 1f31ec810c7a..7fe51ba4f81c 100644
--- a/tests/qemuxmlconftest.c
+++ b/tests/qemuxmlconftest.c
@@ -2587,6 +2587,7 @@ mymain(void)
 
     DO_TEST_CAPS_LATEST("pcihole64");
     DO_TEST_CAPS_LATEST("pcihole64-q35");
+    DO_TEST_CAPS_ARCH_LATEST("pcihole64-virt", "aarch64");
 
     DO_TEST_CAPS_ARCH_LATEST("arm-vexpressa9-nodevs", "aarch64");
     DO_TEST_CAPS_ARCH_LATEST("arm-vexpressa9-basic", "aarch64");
-- 
2.46.0

On Wed, May 14, 2025 at 05:18:54PM -0700, Matthew R. Ochs wrote:
> Add a pcihole64 test for the aarch64 virt machine that verifies the
> value is propagated to the highmem-mmio-size virt machine parameter.
> 
> Signed-off-by: Matthew R. Ochs <mochs@nvidia.com>
> ---
>  .../pcihole64-virt.aarch64-latest.args        | 31 +++++++++++++++++++
>  .../pcihole64-virt.aarch64-latest.xml         | 29 +++++++++++++++++
>  tests/qemuxmlconfdata/pcihole64-virt.xml      | 17 ++++++++++
>  tests/qemuxmlconftest.c                       |  1 +
>  4 files changed, 78 insertions(+)
>  create mode 100644 tests/qemuxmlconfdata/pcihole64-virt.aarch64-latest.args
>  create mode 100644 tests/qemuxmlconfdata/pcihole64-virt.aarch64-latest.xml
>  create mode 100644 tests/qemuxmlconfdata/pcihole64-virt.xml

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|