1. Patchew
  2. Libvirt
  3. [PATCH 0/2] tests: Add capabilities for QEMU 10.0 on aarch64
  4. View patch

[PATCH 1/2] tests: Use collie instead of borzoi for aarch64 tests

Matthew R. Ochs via Devel posted 2 patches 4 months ago
[PATCH 1/2] tests: Use collie instead of borzoi for aarch64 tests
Posted by Matthew R. Ochs via Devel 4 months ago 
The borzoi machine type was dropped in QEMU 9.2.0, so let's
use a different machine type with no ACPI support and no
implicit USB controller instead.

Signed-off-by: Matthew R. Ochs <mochs@nvidia.com>
---
 tests/qemuxmlconfdata/aarch64-noacpi-acpi.aarch64-latest.err    | 2 +-
 tests/qemuxmlconfdata/aarch64-noacpi-acpi.xml                   | 2 +-
 .../aarch64-nousb-minimal.aarch64-latest.abi-update.args        | 2 +-
 .../aarch64-nousb-minimal.aarch64-latest.abi-update.xml         | 2 +-
 tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.args | 2 +-
 tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.xml  | 2 +-
 tests/qemuxmlconfdata/aarch64-nousb-minimal.xml                 | 2 +-
 .../usb-controller-default-fallback-nousb.aarch64-latest.args   | 2 +-
 .../usb-controller-default-fallback-nousb.aarch64-latest.xml    | 2 +-
 .../usb-controller-default-nousb.aarch64-latest.args            | 2 +-
 .../usb-controller-default-nousb.aarch64-latest.xml             | 2 +-
 tests/qemuxmlconfdata/usb-controller-default-nousb.xml          | 2 +-
 ...usb-controller-default-unavailable-nousb.aarch64-latest.args | 2 +-
 .../usb-controller-default-unavailable-nousb.aarch64-latest.xml | 2 +-
 tests/qemuxmlconftest.c                                         | 2 +-
 15 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/tests/qemuxmlconfdata/aarch64-noacpi-acpi.aarch64-latest.err b/tests/qemuxmlconfdata/aarch64-noacpi-acpi.aarch64-latest.err
index 5f379d56ce41..d10bbb1b3e05 100644
--- a/tests/qemuxmlconfdata/aarch64-noacpi-acpi.aarch64-latest.err
+++ b/tests/qemuxmlconfdata/aarch64-noacpi-acpi.aarch64-latest.err
@@ -1 +1 @@
-unsupported configuration: machine type 'borzoi' does not support ACPI
+unsupported configuration: machine type 'collie' does not support ACPI
diff --git a/tests/qemuxmlconfdata/aarch64-noacpi-acpi.xml b/tests/qemuxmlconfdata/aarch64-noacpi-acpi.xml
index 10dbeabd6d52..7b5528d612b6 100644
--- a/tests/qemuxmlconfdata/aarch64-noacpi-acpi.xml
+++ b/tests/qemuxmlconfdata/aarch64-noacpi-acpi.xml
@@ -5,7 +5,7 @@
   <vcpu placement='static'>1</vcpu>
   <os>
     <!-- machine type doesn't matter as long as it has no ACPI -->
-    <type arch='aarch64' machine='borzoi'>hvm</type>
+    <type arch='aarch64' machine='collie'>hvm</type>
   </os>
   <features>
     <acpi/>
diff --git a/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.args b/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.args
index a3d0f7a4fcf5..24f770b92865 100644
--- a/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.args
+++ b/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.args
@@ -10,7 +10,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-aarch64test/.config \
 -name guest=aarch64test,debug-threads=on \
 -S \
 -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-aarch64test/master-key.aes"}' \
--machine borzoi,usb=off,dump-guest-core=off \
+-machine collie,usb=off,dump-guest-core=off \
 -accel kvm \
 -cpu host \
 -m size=1048576k \
diff --git a/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.xml b/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.xml
index 9bf4af4f7433..e3f04fbbff4a 100644
--- a/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.xml
+++ b/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.xml
@@ -5,7 +5,7 @@
   <currentMemory unit='KiB'>1048576</currentMemory>
   <vcpu placement='static'>1</vcpu>
   <os>
-    <type arch='aarch64' machine='borzoi'>hvm</type>
+    <type arch='aarch64' machine='collie'>hvm</type>
     <boot dev='hd'/>
   </os>
   <cpu mode='host-passthrough' check='none'/>
diff --git a/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.args b/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.args
index a3d0f7a4fcf5..24f770b92865 100644
--- a/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.args
+++ b/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.args
@@ -10,7 +10,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-aarch64test/.config \
 -name guest=aarch64test,debug-threads=on \
 -S \
 -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-aarch64test/master-key.aes"}' \
--machine borzoi,usb=off,dump-guest-core=off \
+-machine collie,usb=off,dump-guest-core=off \
 -accel kvm \
 -cpu host \
 -m size=1048576k \
diff --git a/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.xml b/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.xml
index 9bf4af4f7433..e3f04fbbff4a 100644
--- a/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.xml
+++ b/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.xml
@@ -5,7 +5,7 @@
   <currentMemory unit='KiB'>1048576</currentMemory>
   <vcpu placement='static'>1</vcpu>
   <os>
-    <type arch='aarch64' machine='borzoi'>hvm</type>
+    <type arch='aarch64' machine='collie'>hvm</type>
     <boot dev='hd'/>
   </os>
   <cpu mode='host-passthrough' check='none'/>
diff --git a/tests/qemuxmlconfdata/aarch64-nousb-minimal.xml b/tests/qemuxmlconfdata/aarch64-nousb-minimal.xml
index 64cd74e36574..6505122cb8d5 100644
--- a/tests/qemuxmlconfdata/aarch64-nousb-minimal.xml
+++ b/tests/qemuxmlconfdata/aarch64-nousb-minimal.xml
@@ -5,7 +5,7 @@
   <vcpu placement='static'>1</vcpu>
   <os>
     <!-- machine type doesn't matter as long as it has no implicit USB -->
-    <type arch='aarch64' machine='borzoi'>hvm</type>
+    <type arch='aarch64' machine='collie'>hvm</type>
   </os>
   <cpu mode='host-passthrough'/>
   <devices>
diff --git a/tests/qemuxmlconfdata/usb-controller-default-fallback-nousb.aarch64-latest.args b/tests/qemuxmlconfdata/usb-controller-default-fallback-nousb.aarch64-latest.args
index 6cfa04a0f49e..2644394f977f 100644
--- a/tests/qemuxmlconfdata/usb-controller-default-fallback-nousb.aarch64-latest.args
+++ b/tests/qemuxmlconfdata/usb-controller-default-fallback-nousb.aarch64-latest.args
@@ -10,7 +10,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-aarch64test/.config \
 -name guest=aarch64test,debug-threads=on \
 -S \
 -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-aarch64test/master-key.aes"}' \
--machine borzoi,usb=off,dump-guest-core=off \
+-machine collie,usb=off,dump-guest-core=off \
 -accel kvm \
 -cpu host \
 -m size=1048576k \
diff --git a/tests/qemuxmlconfdata/usb-controller-default-fallback-nousb.aarch64-latest.xml b/tests/qemuxmlconfdata/usb-controller-default-fallback-nousb.aarch64-latest.xml
index 2f71d294a7a6..a01dd15168c2 100644
--- a/tests/qemuxmlconfdata/usb-controller-default-fallback-nousb.aarch64-latest.xml
+++ b/tests/qemuxmlconfdata/usb-controller-default-fallback-nousb.aarch64-latest.xml
@@ -5,7 +5,7 @@
   <currentMemory unit='KiB'>1048576</currentMemory>
   <vcpu placement='static'>1</vcpu>
   <os>
-    <type arch='aarch64' machine='borzoi'>hvm</type>
+    <type arch='aarch64' machine='collie'>hvm</type>
     <boot dev='hd'/>
   </os>
   <cpu mode='host-passthrough' check='none'/>
diff --git a/tests/qemuxmlconfdata/usb-controller-default-nousb.aarch64-latest.args b/tests/qemuxmlconfdata/usb-controller-default-nousb.aarch64-latest.args
index 6cfa04a0f49e..2644394f977f 100644
--- a/tests/qemuxmlconfdata/usb-controller-default-nousb.aarch64-latest.args
+++ b/tests/qemuxmlconfdata/usb-controller-default-nousb.aarch64-latest.args
@@ -10,7 +10,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-aarch64test/.config \
 -name guest=aarch64test,debug-threads=on \
 -S \
 -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-aarch64test/master-key.aes"}' \
--machine borzoi,usb=off,dump-guest-core=off \
+-machine collie,usb=off,dump-guest-core=off \
 -accel kvm \
 -cpu host \
 -m size=1048576k \
diff --git a/tests/qemuxmlconfdata/usb-controller-default-nousb.aarch64-latest.xml b/tests/qemuxmlconfdata/usb-controller-default-nousb.aarch64-latest.xml
index 2f71d294a7a6..a01dd15168c2 100644
--- a/tests/qemuxmlconfdata/usb-controller-default-nousb.aarch64-latest.xml
+++ b/tests/qemuxmlconfdata/usb-controller-default-nousb.aarch64-latest.xml
@@ -5,7 +5,7 @@
   <currentMemory unit='KiB'>1048576</currentMemory>
   <vcpu placement='static'>1</vcpu>
   <os>
-    <type arch='aarch64' machine='borzoi'>hvm</type>
+    <type arch='aarch64' machine='collie'>hvm</type>
     <boot dev='hd'/>
   </os>
   <cpu mode='host-passthrough' check='none'/>
diff --git a/tests/qemuxmlconfdata/usb-controller-default-nousb.xml b/tests/qemuxmlconfdata/usb-controller-default-nousb.xml
index c8bd07ad5d0c..83a405800fbe 100644
--- a/tests/qemuxmlconfdata/usb-controller-default-nousb.xml
+++ b/tests/qemuxmlconfdata/usb-controller-default-nousb.xml
@@ -5,7 +5,7 @@
   <vcpu placement='static'>1</vcpu>
   <os>
     <!-- machine type doesn't matter as long as it has no implicit USB -->
-    <type arch='aarch64' machine='borzoi'>hvm</type>
+    <type arch='aarch64' machine='collie'>hvm</type>
   </os>
   <cpu mode='host-passthrough'/>
   <devices>
diff --git a/tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.aarch64-latest.args b/tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.aarch64-latest.args
index 6cfa04a0f49e..2644394f977f 100644
--- a/tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.aarch64-latest.args
+++ b/tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.aarch64-latest.args
@@ -10,7 +10,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-aarch64test/.config \
 -name guest=aarch64test,debug-threads=on \
 -S \
 -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-aarch64test/master-key.aes"}' \
--machine borzoi,usb=off,dump-guest-core=off \
+-machine collie,usb=off,dump-guest-core=off \
 -accel kvm \
 -cpu host \
 -m size=1048576k \
diff --git a/tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.aarch64-latest.xml b/tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.aarch64-latest.xml
index 2f71d294a7a6..a01dd15168c2 100644
--- a/tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.aarch64-latest.xml
+++ b/tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.aarch64-latest.xml
@@ -5,7 +5,7 @@
   <currentMemory unit='KiB'>1048576</currentMemory>
   <vcpu placement='static'>1</vcpu>
   <os>
-    <type arch='aarch64' machine='borzoi'>hvm</type>
+    <type arch='aarch64' machine='collie'>hvm</type>
     <boot dev='hd'/>
   </os>
   <cpu mode='host-passthrough' check='none'/>
diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c
index be2fba9e4dd2..1f31ec810c7a 100644
--- a/tests/qemuxmlconftest.c
+++ b/tests/qemuxmlconftest.c
@@ -1764,7 +1764,7 @@ mymain(void)
      *     - firmware-manual-efi-acpi-aarch64
      *     - firmware-auto-efi-loongarch64
      *
-     *  - negative case for aarch64 with 'borzoi' machine not supporting ACPI
+     *  - negative case for aarch64 with 'collie' machine not supporting ACPI
      *
      *  - s390x has hack to strip ACPI to preserve migration of old configs,
      *    but should produce error when ABI_UPDATE is requested
-- 
2.46.0
Re: [PATCH 1/2] tests: Use collie instead of borzoi for aarch64 tests
Posted by Peter Krempa via Devel 4 months ago 
On Wed, May 07, 2025 at 16:38:38 -0700, Matthew R. Ochs via Devel wrote:
> The borzoi machine type was dropped in QEMU 9.2.0, so let's
> use a different machine type with no ACPI support and no
> implicit USB controller instead.
> 
> Signed-off-by: Matthew R. Ochs <mochs@nvidia.com>
> ---
>  tests/qemuxmlconfdata/aarch64-noacpi-acpi.aarch64-latest.err    | 2 +-
>  tests/qemuxmlconfdata/aarch64-noacpi-acpi.xml                   | 2 +-
>  .../aarch64-nousb-minimal.aarch64-latest.abi-update.args        | 2 +-
>  .../aarch64-nousb-minimal.aarch64-latest.abi-update.xml         | 2 +-
>  tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.args | 2 +-
>  tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.xml  | 2 +-
>  tests/qemuxmlconfdata/aarch64-nousb-minimal.xml                 | 2 +-
>  .../usb-controller-default-fallback-nousb.aarch64-latest.args   | 2 +-
>  .../usb-controller-default-fallback-nousb.aarch64-latest.xml    | 2 +-
>  .../usb-controller-default-nousb.aarch64-latest.args            | 2 +-
>  .../usb-controller-default-nousb.aarch64-latest.xml             | 2 +-
>  tests/qemuxmlconfdata/usb-controller-default-nousb.xml          | 2 +-
>  ...usb-controller-default-unavailable-nousb.aarch64-latest.args | 2 +-
>  .../usb-controller-default-unavailable-nousb.aarch64-latest.xml | 2 +-
>  tests/qemuxmlconftest.c                                         | 2 +-
>  15 files changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/tests/qemuxmlconfdata/aarch64-noacpi-acpi.aarch64-latest.err b/tests/qemuxmlconfdata/aarch64-noacpi-acpi.aarch64-latest.err
> index 5f379d56ce41..d10bbb1b3e05 100644
> --- a/tests/qemuxmlconfdata/aarch64-noacpi-acpi.aarch64-latest.err
> +++ b/tests/qemuxmlconfdata/aarch64-noacpi-acpi.aarch64-latest.err
> @@ -1 +1 @@
> -unsupported configuration: machine type 'borzoi' does not support ACPI
> +unsupported configuration: machine type 'collie' does not support ACPI
> diff --git a/tests/qemuxmlconfdata/aarch64-noacpi-acpi.xml b/tests/qemuxmlconfdata/aarch64-noacpi-acpi.xml
> index 10dbeabd6d52..7b5528d612b6 100644
> --- a/tests/qemuxmlconfdata/aarch64-noacpi-acpi.xml
> +++ b/tests/qemuxmlconfdata/aarch64-noacpi-acpi.xml
> @@ -5,7 +5,7 @@
>    <vcpu placement='static'>1</vcpu>
>    <os>
>      <!-- machine type doesn't matter as long as it has no ACPI -->
> -    <type arch='aarch64' machine='borzoi'>hvm</type>
> +    <type arch='aarch64' machine='collie'>hvm</type>
>    </os>
>    <features>
>      <acpi/>
> diff --git a/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.args b/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.args
> index a3d0f7a4fcf5..24f770b92865 100644
> --- a/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.args
> +++ b/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.args
> @@ -10,7 +10,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-aarch64test/.config \
>  -name guest=aarch64test,debug-threads=on \
>  -S \
>  -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-aarch64test/master-key.aes"}' \
> --machine borzoi,usb=off,dump-guest-core=off \
> +-machine collie,usb=off,dump-guest-core=off \
>  -accel kvm \
>  -cpu host \
>  -m size=1048576k \

I presume you did a s/borzoi/collie herer, without running the test
suite?

When running, the commandline would change a bit more:

+-machine collie,usb=off,dump-guest-core=off,memory-backend=strongarm.sdram \

and also this needed to be added.

+-object '{"qom-type":"memory-backend-ram","id":"strongarm.sdram","size":1073741824}' \


Since these hunks are present in 2/2 you've probably forgot to commit
them here :)

Anyways I'll fix this.

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Re: [PATCH 1/2] tests: Use collie instead of borzoi for aarch64 tests
Posted by Andrea Bolognani via Devel 4 months ago 
On Thu, May 08, 2025 at 07:51:29AM +0200, Peter Krempa wrote:
> On Wed, May 07, 2025 at 16:38:38 -0700, Matthew R. Ochs via Devel wrote:
> > diff --git a/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.args b/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.args
> > index a3d0f7a4fcf5..24f770b92865 100644
> > --- a/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.args
> > +++ b/tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.args
> > @@ -10,7 +10,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-aarch64test/.config \
> >  -name guest=aarch64test,debug-threads=on \
> >  -S \
> >  -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-aarch64test/master-key.aes"}' \
> > --machine borzoi,usb=off,dump-guest-core=off \
> > +-machine collie,usb=off,dump-guest-core=off \
> >  -accel kvm \
> >  -cpu host \
> >  -m size=1048576k \
>
> I presume you did a s/borzoi/collie herer, without running the test
> suite?

They seems to have gone further than that: earlier in the diff you
can spot:

> diff --git a/tests/qemucapabilitiesdata/caps_8.2.0_aarch64.replies b/tests/qemucapabilitiesdata/caps_8.2.0_aarch64.replies
> index 203774ecff..ed72c6fdfa 100644
> --- a/tests/qemucapabilitiesdata/caps_8.2.0_aarch64.replies
> +++ b/tests/qemucapabilitiesdata/caps_8.2.0_aarch64.replies
> @@ -27289,7 +27289,7 @@
>        "parent": "sys-bus-device"
>      },
>      {
> -      "name": "borzoi-machine",
> +      "name": "collie-machine",
>        "parent": "spitz-common"
>      },
>      {
> --- a/tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml
> +++ b/tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml
> @@ -240,7 +240,7 @@
>    <machine type='kvm' name='qcom-dc-scm-v1-bmc' maxCpus='2' defaultRAMid='ram' acpi='no'/>
>    <machine type='kvm' name='mori-bmc' maxCpus='2' defaultCPU='cortex-a9-arm-cpu' defaultRAMid='ram' acpi='no'/>
>    <machine type='kvm' name='ast2600-evb' maxCpus='2' defaultRAMid='ram' acpi='no'/>
> -  <machine type='kvm' name='borzoi' maxCpus='1' defaultCPU='pxa270-c0-arm-cpu' acpi='no'/>
> +  <machine type='kvm' name='collie' maxCpus='1' defaultCPU='pxa270-c0-arm-cpu' acpi='no'/>
>    <machine type='kvm' name='tiogapass-bmc' maxCpus='1' defaultRAMid='ram' acpi='no'/>
>    <machine type='kvm' name='spitz' maxCpus='1' defaultCPU='pxa270-c0-arm-cpu' acpi='no'/>
>    <machine type='kvm' name='virt-2.7' maxCpus='255' defaultCPU='cortex-a15-arm-cpu' numaMemSupported='yes' defaultRAMid='mach-virt.ram' acpi='yes'/>

which seems to indicate that they have just applied a naive
s/borzoi/collie/ without considering the semantics. With this patch
applied:

  $ grep collie tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml
    <machine type='kvm' name='collie' maxCpus='1'
defaultCPU='pxa270-c0-arm-cpu' acpi='no'/>
    <machine type='kvm' name='collie' maxCpus='1'
defaultCPU='sa1110-arm-cpu' defaultRAMid='strongarm.sdram' acpi='no'/>
    <machine type='tcg' name='collie' maxCpus='1'
defaultCPU='pxa270-c0-arm-cpu' acpi='no'/>
    <machine type='tcg' name='collie' maxCpus='1'
defaultCPU='sa1110-arm-cpu' defaultRAMid='strongarm.sdram' acpi='no'/>

i.e. the collie machine shows up twice, with completely different
attributes associated with it each time, in the resulting
capabilities data. This obviously will not make any sense to a user
or application parsing the information.

> When running, the commandline would change a bit more:
>
> +-machine collie,usb=off,dump-guest-core=off,memory-backend=strongarm.sdram \
>
> and also this needed to be added.
>
> +-object '{"qom-type":"memory-backend-ram","id":"strongarm.sdram","size":1073741824}' \

That was all present in my patch from earlier this year[1], which
this one is clearly based on.

And "based on" is a very generous term in this case, since what the
author appears to have done is take it outright, leaving the commit
message completely unchanged, ripping out the original authorship and
reposting it as their own - with some fresh new bugs sprinkled in for
good measure. Which needless to say is not just highly questionable
from a legal standpoint but also just deeply, deeply uncool.

I'm going to assume that this was done with no ill intent behind it,
especially since by CCing me to the series they did the exact
opposite of trying to cover their tracks ;)

Still, this contribution is completely unacceptable due to both
technical and legal factors and should be disregarded.

> Since these hunks are present in 2/2 you've probably forgot to commit
> them here :)
>
> Anyways I'll fix this.
>
> Reviewed-by: Peter Krempa <pkrempa@redhat.com>

100% NACK. Please don't push any of this.


[1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/2PIQSKIV3E3B2W6YZQ3O5RHEK235OTBK/
-- 
Andrea Bolognani / Red Hat / Virtualization
Re: [PATCH 1/2] tests: Use collie instead of borzoi for aarch64 tests
Posted by Matt Ochs via Devel 4 months ago 
Hi Andrea,

> On May 8, 2025, at 4:00 AM, Andrea Bolognani <abologna@redhat.com> wrote:
> On Thu, May 08, 2025 at 07:51:29AM +0200, Peter Krempa wrote:
>> On Wed, May 07, 2025 at 16:38:38 -0700, Matthew R. Ochs via Devel wrote:
> 
> That was all present in my patch from earlier this year[1], which
> this one is clearly based on.
> 
> And "based on" is a very generous term in this case, since what the
> author appears to have done is take it outright, leaving the commit
> message completely unchanged, ripping out the original authorship and
> reposting it as their own - with some fresh new bugs sprinkled in for
> good measure. Which needless to say is not just highly questionable
> from a legal standpoint but also just deeply, deeply uncool.
> 
> I'm going to assume that this was done with no ill intent behind it,
> especially since by CCing me to the series they did the exact
> opposite of trying to cover their tracks ;)
> 
> Still, this contribution is completely unacceptable due to both
> technical and legal factors and should be disregarded.

My sincere apologies, this was my first time trying to refresh a series
like this and I obviously went about it the wrong way. I commit to getting
it right next time.


-matt
Re: [PATCH 1/2] tests: Use collie instead of borzoi for aarch64 tests
Posted by Andrea Bolognani via Devel 4 months ago 
On Thu, May 08, 2025 at 06:58:45PM +0000, Matt Ochs wrote:
> On May 8, 2025, at 4:00 AM, Andrea Bolognani <abologna@redhat.com> wrote:
> > That was all present in my patch from earlier this year[1], which
> > this one is clearly based on.
> >
> > And "based on" is a very generous term in this case, since what the
> > author appears to have done is take it outright, leaving the commit
> > message completely unchanged, ripping out the original authorship and
> > reposting it as their own - with some fresh new bugs sprinkled in for
> > good measure. Which needless to say is not just highly questionable
> > from a legal standpoint but also just deeply, deeply uncool.
> >
> > I'm going to assume that this was done with no ill intent behind it,
> > especially since by CCing me to the series they did the exact
> > opposite of trying to cover their tracks ;)
> >
> > Still, this contribution is completely unacceptable due to both
> > technical and legal factors and should be disregarded.
>
> My sincere apologies, this was my first time trying to refresh a series
> like this and I obviously went about it the wrong way. I commit to getting
> it right next time.

Apologies accepted with no reservations or grudges on my end. We're
cool. But I felt that it was critical to stress the importance of
getting authorship and attribution right - open source doesn't mean
that it's a free for all. Lesson learned, let's move on :)

-- 
Andrea Bolognani / Red Hat / Virtualization
Re: [PATCH 1/2] tests: Use collie instead of borzoi for aarch64 tests
Posted by Andrea Bolognani via Devel 4 months ago 
On Thu, May 08, 2025 at 02:00:07AM -0700, Andrea Bolognani wrote:
> On Thu, May 08, 2025 at 07:51:29AM +0200, Peter Krempa wrote:
> [...] seems to indicate that they have just applied a naive
> s/borzoi/collie/ without considering the semantics. With this patch
> applied:
>
>   $ grep collie tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml
>     <machine type='kvm' name='collie' maxCpus='1' defaultCPU='pxa270-c0-arm-cpu' acpi='no'/>
>     <machine type='kvm' name='collie' maxCpus='1' defaultCPU='sa1110-arm-cpu' defaultRAMid='strongarm.sdram' acpi='no'/>
>     <machine type='tcg' name='collie' maxCpus='1' defaultCPU='pxa270-c0-arm-cpu' acpi='no'/>
>     <machine type='tcg' name='collie' maxCpus='1' defaultCPU='sa1110-arm-cpu' defaultRAMid='strongarm.sdram' acpi='no'/>
>
> i.e. the collie machine shows up twice, with completely different
> attributes associated with it each time, in the resulting
> capabilities data. This obviously will not make any sense to a user
> or application parsing the information.

Disregard this part. I was looking at an earlier version of the
patch set which displayed this behavior, but upon further inspection
I see that's not present in the version that was posted.

The NACK stands for the other reasons.

-- 
Andrea Bolognani / Red Hat / Virtualization

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.