Finish the work to stop hardcoding paths at build time

[PATCH 07/20] build-aux: add missing definition of PERL variable

Posted by Daniel P. Berrangé via Devel 4 months, 1 week ago

From: Daniel P. Berrangé <berrange@redhat.com>

Currently $(PERL) is expanding to nothing, but the spacing-check.pl test
luckily still works via the shebang.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 build-aux/Makefile.in | 1 +
 build-aux/meson.build | 1 +
 2 files changed, 2 insertions(+)

diff --git a/build-aux/Makefile.in b/build-aux/Makefile.in
index db44ee36a4..f30773e263 100644
--- a/build-aux/Makefile.in
+++ b/build-aux/Makefile.in
@@ -6,6 +6,7 @@ FLAKE8 = @flake8_path@
 BLACK = @black_path@
 RUNUTF8 = @runutf8@
 PYTHON = @PYTHON3@
+PERL = @PERL@
 GREP = @GREP@
 SED = @SED@
 AWK = @AWK@
diff --git a/build-aux/meson.build b/build-aux/meson.build
index 06be6ab6c8..bcd10e89f2 100644
--- a/build-aux/meson.build
+++ b/build-aux/meson.build
@@ -42,6 +42,7 @@ if git and tests_enabled[0]
     'black_path': black_path,
     'runutf8': ' '.join(runutf8),
     'PYTHON3': python3_prog.full_path(),
+    'PERL': perl_prog.full_path(),
     'GREP': grep_prog.full_path(),
     'SED': sed_prog.full_path(),
     'AWK': awk_prog.full_path(),
-- 
2.49.0

Re: [PATCH 07/20] build-aux: add missing definition of PERL variable

Posted by Peter Krempa via Devel 4 months, 1 week ago

On Tue, Apr 29, 2025 at 12:14:07 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé <berrange@redhat.com>
> 
> Currently $(PERL) is expanding to nothing, but the spacing-check.pl test
> luckily still works via the shebang.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  build-aux/Makefile.in | 1 +
>  build-aux/meson.build | 1 +
>  2 files changed, 2 insertions(+)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>