bhyve: capabilities: advertise RNG device support

[PATCH] bhyve: capabilities: advertise RNG device support

Posted by Roman Bogorodskiy 8 months, 1 week ago

Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
---
 src/bhyve/bhyve_capabilities.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c
index 37ae5d2872..36a092a819 100644
--- a/src/bhyve/bhyve_capabilities.c
+++ b/src/bhyve/bhyve_capabilities.c
@@ -109,6 +109,16 @@ virBhyveDomainCapsFill(virDomainCaps *caps,
         VIR_DOMAIN_CAPS_ENUM_SET(caps->video.modelType, VIR_DOMAIN_VIDEO_TYPE_GOP);
     }
 
+    if (bhyvecaps & BHYVE_CAP_VIRTIO_RND) {
+        caps->rng.supported = VIR_TRISTATE_BOOL_YES;
+        caps->rng.model.report = true;
+        caps->rng.backendModel.report = true;
+
+        VIR_DOMAIN_CAPS_ENUM_SET(caps->rng.model, VIR_DOMAIN_RNG_MODEL_VIRTIO);
+        VIR_DOMAIN_CAPS_ENUM_SET(caps->rng.backendModel,
+                                 VIR_DOMAIN_RNG_BACKEND_RANDOM);
+    }
+
     caps->hostdev.supported = VIR_TRISTATE_BOOL_NO;
     caps->features[VIR_DOMAIN_CAPS_FEATURE_IOTHREADS] = VIR_TRISTATE_BOOL_NO;
     caps->features[VIR_DOMAIN_CAPS_FEATURE_VMCOREINFO] = VIR_TRISTATE_BOOL_NO;
-- 
2.49.0

Re: [PATCH] bhyve: capabilities: advertise RNG device support

Posted by Daniel P. Berrangé via Devel 8 months, 1 week ago

On Mon, Apr 14, 2025 at 07:45:25PM +0200, Roman Bogorodskiy wrote:
> Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
> ---
>  src/bhyve/bhyve_capabilities.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c
> index 37ae5d2872..36a092a819 100644
> --- a/src/bhyve/bhyve_capabilities.c
> +++ b/src/bhyve/bhyve_capabilities.c
> @@ -109,6 +109,16 @@ virBhyveDomainCapsFill(virDomainCaps *caps,
>          VIR_DOMAIN_CAPS_ENUM_SET(caps->video.modelType, VIR_DOMAIN_VIDEO_TYPE_GOP);
>      }
>  
> +    if (bhyvecaps & BHYVE_CAP_VIRTIO_RND) {
> +        caps->rng.supported = VIR_TRISTATE_BOOL_YES;
> +        caps->rng.model.report = true;
> +        caps->rng.backendModel.report = true;
> +
> +        VIR_DOMAIN_CAPS_ENUM_SET(caps->rng.model, VIR_DOMAIN_RNG_MODEL_VIRTIO);
> +        VIR_DOMAIN_CAPS_ENUM_SET(caps->rng.backendModel,
> +                                 VIR_DOMAIN_RNG_BACKEND_RANDOM);
> +    }
> +
>      caps->hostdev.supported = VIR_TRISTATE_BOOL_NO;
>      caps->features[VIR_DOMAIN_CAPS_FEATURE_IOTHREADS] = VIR_TRISTATE_BOOL_NO;
>      caps->features[VIR_DOMAIN_CAPS_FEATURE_VMCOREINFO] = VIR_TRISTATE_BOOL_NO;

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|