storage: vol-create bug fix

[PATCH v2 0/2] storage: vol-create bug fix

Posted by Kirill Shchetiniuk via Devel 8 months, 1 week ago

When new volume was created using 'vol-create' and '--validate' option
an error occured due to invalid flags passed downward.

Resolves: https://lists.libvirt.org/archives/list/users@lists.libvirt.org/thread/7WQ2IRSPWKKV5S3N3YJTFOMAJTZJFN7H/


Kirill Shchetiniuk (2):
  storage: virStorageVolDefParse and storageVolCreateXML flags fix
  NEWS: mention vol-create bug fix

 NEWS.rst                     | 5 +++++
 src/conf/storage_conf.c      | 2 ++
 src/storage/storage_driver.c | 4 +++-
 3 files changed, 10 insertions(+), 1 deletion(-)

--
2.48.1

Re: [PATCH v2 0/2] storage: vol-create bug fix

Posted by Ján Tomko via Devel 8 months, 1 week ago

On a Wednesday in 2025, Kirill Shchetiniuk via Devel wrote:
>When new volume was created using 'vol-create' and '--validate' option
>an error occured due to invalid flags passed downward.
>
>Resolves: https://lists.libvirt.org/archives/list/users@lists.libvirt.org/thread/7WQ2IRSPWKKV5S3N3YJTFOMAJTZJFN7H/
>
>

Please configure your git format-patch to format the From header in the
e-mails:
https://www.libvirt.org/submitting-patches.html#git-configuration

Otherwise they show up as authored by the list in the commit history:
Author:     Kirill Shchetiniuk via Devel <devel@lists.libvirt.org>
https://gitlab.com/libvirt/libvirt/-/commit/cdf599cfb6a7d3a8ce6410ff2e303493bcbe484b

Jano

>Kirill Shchetiniuk (2):
>  storage: virStorageVolDefParse and storageVolCreateXML flags fix
>  NEWS: mention vol-create bug fix
>
> NEWS.rst                     | 5 +++++
> src/conf/storage_conf.c      | 2 ++
> src/storage/storage_driver.c | 4 +++-
> 3 files changed, 10 insertions(+), 1 deletion(-)
>
>--
>2.48.1
>

Re: [PATCH v2 0/2] storage: vol-create bug fix

Posted by Michal Prívozník via Devel 8 months, 1 week ago

On 4/9/25 10:43, Kirill Shchetiniuk via Devel wrote:
> When new volume was created using 'vol-create' and '--validate' option
> an error occured due to invalid flags passed downward.
> 
> Resolves: https://lists.libvirt.org/archives/list/users@lists.libvirt.org/thread/7WQ2IRSPWKKV5S3N3YJTFOMAJTZJFN7H/
> 
> 
> Kirill Shchetiniuk (2):
>   storage: virStorageVolDefParse and storageVolCreateXML flags fix
>   NEWS: mention vol-create bug fix
> 
>  NEWS.rst                     | 5 +++++
>  src/conf/storage_conf.c      | 2 ++
>  src/storage/storage_driver.c | 4 +++-
>  3 files changed, 10 insertions(+), 1 deletion(-)
> 
> --
> 2.48.1
> 

I'm fixing all the small nits and merging.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal