[PATCH 0/3] ch: monitor daemonization, sync after reboot, and shutdown fixes

Kirill Shchetiniuk via Devel posted 3 patches 8 months, 4 weeks ago
Failed in applying to current master (apply log)
src/ch/ch_domain.c  |  1 +
src/ch/ch_domain.h  |  1 +
src/ch/ch_events.c  |  8 ++++----
src/ch/ch_monitor.c | 24 ++++++++++++++++++++++--
src/ch/ch_process.c | 18 +++++++++++++++++-
src/ch/ch_process.h |  2 ++
6 files changed, 47 insertions(+), 7 deletions(-)
[PATCH 0/3] ch: monitor daemonization, sync after reboot, and shutdown fixes
Posted by Kirill Shchetiniuk via Devel 8 months, 4 weeks ago
1. Run CH monitor as a daemon
Made the monitor process daemonized to prevent VM termination if
the CH driver crashes. Added pidfile for daemon's pid aquiring and tracking
as well as its init.

2. Update domain info after reboot
Fixed an issue where domain properties (e.g., serial console path)
were not updated after VM reboot. Added VIR_CH_EVENT_VM_REBOOTED
handling to keep the transient domain definition consistent.

3. Update VM shutdown event handler
VM monitor was still up even if VM was shut off, which led to an
inability to start the domain again.

virsh # shutdown ch-test
Domain 'ch-test' is being shutdown

virsh # list
 Id       Name      State
 ------------------------------
 722117   ch-test   shut off

Ensured the CH monitor process terminates along with the
VM shutdown (e.g., executed using virsh). Updated
virCHEventStopProcess to have proper job type.

Kirill Shchetiniuk (3):
  ch: virCHMonitorNew() run new CH monitor daemonized
  ch: virCHProcessEvent() update domain info after reboot
  ch: virCHProcessEvent() vm shutdown event handler fix

 src/ch/ch_domain.c  |  1 +
 src/ch/ch_domain.h  |  1 +
 src/ch/ch_events.c  |  8 ++++----
 src/ch/ch_monitor.c | 24 ++++++++++++++++++++++--
 src/ch/ch_process.c | 18 +++++++++++++++++-
 src/ch/ch_process.h |  2 ++
 6 files changed, 47 insertions(+), 7 deletions(-)

--
2.48.1
Re: [PATCH 0/3] ch: monitor daemonization, sync after reboot, and shutdown fixes
Posted by Michal Prívozník via Devel 8 months, 2 weeks ago
On 3/25/25 15:11, Kirill Shchetiniuk via Devel wrote:
> 1. Run CH monitor as a daemon
> Made the monitor process daemonized to prevent VM termination if
> the CH driver crashes. Added pidfile for daemon's pid aquiring and tracking
> as well as its init.
> 
> 2. Update domain info after reboot
> Fixed an issue where domain properties (e.g., serial console path)
> were not updated after VM reboot. Added VIR_CH_EVENT_VM_REBOOTED
> handling to keep the transient domain definition consistent.
> 
> 3. Update VM shutdown event handler
> VM monitor was still up even if VM was shut off, which led to an
> inability to start the domain again.
> 
> virsh # shutdown ch-test
> Domain 'ch-test' is being shutdown
> 
> virsh # list
>  Id       Name      State
>  ------------------------------
>  722117   ch-test   shut off
> 
> Ensured the CH monitor process terminates along with the
> VM shutdown (e.g., executed using virsh). Updated
> virCHEventStopProcess to have proper job type.
> 
> Kirill Shchetiniuk (3):
>   ch: virCHMonitorNew() run new CH monitor daemonized
>   ch: virCHProcessEvent() update domain info after reboot
>   ch: virCHProcessEvent() vm shutdown event handler fix
> 
>  src/ch/ch_domain.c  |  1 +
>  src/ch/ch_domain.h  |  1 +
>  src/ch/ch_events.c  |  8 ++++----
>  src/ch/ch_monitor.c | 24 ++++++++++++++++++++++--
>  src/ch/ch_process.c | 18 +++++++++++++++++-
>  src/ch/ch_process.h |  2 ++
>  6 files changed, 47 insertions(+), 7 deletions(-)
> 
> --
> 2.48.1
> 

I'm fixing 1/3 and merging.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal