[v2] Add typed param constants for guest info and domain stats APIs

[PATCH v2 10/23] src: expand docs for guest info constant version handling

Posted by Daniel P. Berrangé 22 hours ago

Explain that the 11.2.0 release dates are mostly reflecting when the
constant was first added, not when the key was introduced.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/libvirt-domain.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 390f54d46e..82de3ede24 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -13299,6 +13299,13 @@ virDomainSetVcpu(virDomainPtr domain,
  * Which, when fsindex==3 and diskindex==7, would result in the
  * key "fs.3.disk.7.serial".
  *
+ * NB, for the VIR_DOMAIN_GUEST_INFO_* constants, if the `Since`
+ * tag is set to `11.2.0` this is usually representing the
+ * release when the constant was first introduced to the public
+ * API. Most of these typed parameter keys will have been
+ * introduced in earlier libvirt releases, prior to the definition
+ * of the constants.
+ *
  * Returns 0 on success, -1 on error.
  *
  * Since: 5.7.0
-- 
2.48.1

Re: [PATCH v2 10/23] src: expand docs for guest info constant version handling

Posted by Peter Krempa 20 hours ago

On Tue, Mar 11, 2025 at 14:24:16 +0000, Daniel P. Berrangé wrote:
> Explain that the 11.2.0 release dates are mostly reflecting when the
> constant was first added, not when the key was introduced.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  src/libvirt-domain.c | 7 +++++++
>  1 file changed, 7 insertions(+)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>