[v2] qemu: Improve opening and verifying save images

[PATCH V2 0/3] qemu: Improve opening and verifying save images

Jim Fehlig via Devel posted 3 patches 7 months, 1 week ago

Diff against v1
Download series mbox

Failed in applying to current master (apply log)

src/qemu/qemu_driver.c    |  46 ++++---
src/qemu/qemu_saveimage.c | 268 +++++++++++++++++++++++---------------
src/qemu/qemu_saveimage.h |  21 ++-
src/qemu/qemu_snapshot.c  |   9 +-
4 files changed, 207 insertions(+), 137 deletions(-)

Expand all Fold all

[PATCH V2 0/3] qemu: Improve opening and verifying save images

Posted by Jim Fehlig via Devel 7 months, 1 week ago

V2 of https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/DATZFZY6ETRYOQ6ORQ2JIVHBTFGKUBJM/

Changes in V2:
* Move unlinking corrupt save images from qemuSaveImageOpen to the only
  caller using that functionality
* Add a function to read save image header
* Correctly position file pointer of save image for QEMU

Jim Fehlig (3):
  qemu: Move unlinking corrupt save image file to caller
  qemu: Decompose qemuSaveImageOpen
  qemu: Check for valid save image format when verifying image header

 src/qemu/qemu_driver.c    |  46 ++++---
 src/qemu/qemu_saveimage.c | 268 +++++++++++++++++++++++---------------
 src/qemu/qemu_saveimage.h |  21 ++-
 src/qemu/qemu_snapshot.c  |   9 +-
 4 files changed, 207 insertions(+), 137 deletions(-)

-- 
2.43.0

Re: [PATCH V2 0/3] qemu: Improve opening and verifying save images

Posted by Michal Prívozník 7 months, 1 week ago

On 1/31/25 03:29, Jim Fehlig via Devel wrote:
> V2 of https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/DATZFZY6ETRYOQ6ORQ2JIVHBTFGKUBJM/
> 
> Changes in V2:
> * Move unlinking corrupt save images from qemuSaveImageOpen to the only
>   caller using that functionality
> * Add a function to read save image header
> * Correctly position file pointer of save image for QEMU
> 
> Jim Fehlig (3):
>   qemu: Move unlinking corrupt save image file to caller
>   qemu: Decompose qemuSaveImageOpen
>   qemu: Check for valid save image format when verifying image header
> 
>  src/qemu/qemu_driver.c    |  46 ++++---
>  src/qemu/qemu_saveimage.c | 268 +++++++++++++++++++++++---------------
>  src/qemu/qemu_saveimage.h |  21 ++-
>  src/qemu/qemu_snapshot.c  |   9 +-
>  4 files changed, 207 insertions(+), 137 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and merged.

Michal