From: Marc-André Lureau <marcandre.lureau@redhat.com>

glib anti-pattern, since it aborts on OOM.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 src/qemu/qemu_slirp.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/qemu/qemu_slirp.c b/src/qemu/qemu_slirp.c
index 66d9d77c6c..eac7e4cc47 100644
--- a/src/qemu/qemu_slirp.c
+++ b/src/qemu/qemu_slirp.c
@@ -99,12 +99,6 @@ qemuSlirpNewForHelper(const char *helper)
     size_t i, nfeatures;
 
     slirp = qemuSlirpNew();
-    if (!slirp) {
-        virReportError(VIR_ERR_INTERNAL_ERROR,
-                       _("Failed to allocate slirp for '%1$s'"), helper);
-        return NULL;
-    }
-
     cmd = virCommandNewArgList(helper, "--print-capabilities", NULL);
     virCommandSetOutputBuffer(cmd, &output);
     if (virCommandRun(cmd, NULL) < 0)
-- 
2.47.0

On Wed, Jan 29, 2025 at 05:40:25PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> glib anti-pattern, since it aborts on OOM.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  src/qemu/qemu_slirp.c | 6 ------
>  1 file changed, 6 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|