From: Marc-André Lureau <marcandre.lureau@redhat.com>

When compiled with -Doptimization=g

../tools/nss/libvirt_nss_macs.c:155:8: error: ‘jerr’ may be used uninitialized [-Werror=maybe-uninitialized]
  155 |     if (jerr == json_tokener_continue) {
      |        ^

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 tools/nss/libvirt_nss_leases.c | 2 +-
 tools/nss/libvirt_nss_macs.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/nss/libvirt_nss_leases.c b/tools/nss/libvirt_nss_leases.c
index 25ea6b0ce2..4d68787fb2 100644
--- a/tools/nss/libvirt_nss_leases.c
+++ b/tools/nss/libvirt_nss_leases.c
@@ -260,7 +260,7 @@ findLeases(const char *file,
     int ret = -1;
     json_object *jobj = NULL;
     json_tokener *tok = NULL;
-    enum json_tokener_error jerr;
+    enum json_tokener_error jerr = json_tokener_error_parse_eof;
     int jsonflags = JSON_TOKENER_STRICT | JSON_TOKENER_VALIDATE_UTF8;
     char line[1024];
     size_t nreadTotal = 0;
diff --git a/tools/nss/libvirt_nss_macs.c b/tools/nss/libvirt_nss_macs.c
index bac8c0e1bb..c3af9375bc 100644
--- a/tools/nss/libvirt_nss_macs.c
+++ b/tools/nss/libvirt_nss_macs.c
@@ -122,7 +122,7 @@ findMACs(const char *file,
     char line[1024];
     json_object *jobj = NULL;
     json_tokener *tok = NULL;
-    enum json_tokener_error jerr;
+    enum json_tokener_error jerr = json_tokener_error_parse_eof;
     int jsonflags = JSON_TOKENER_STRICT | JSON_TOKENER_VALIDATE_UTF8;
     size_t nreadTotal = 0;
     int rv;
-- 
2.47.0

On Wed, Jan 29, 2025 at 05:40:24PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> When compiled with -Doptimization=g
> 
> ../tools/nss/libvirt_nss_macs.c:155:8: error: ‘jerr’ may be used uninitialized [-Werror=maybe-uninitialized]
>   155 |     if (jerr == json_tokener_continue) {
>       |        ^
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  tools/nss/libvirt_nss_leases.c | 2 +-
>  tools/nss/libvirt_nss_macs.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|