On a Friday in 2025, Daniel P. Berrangé wrote:
>There was a proposal
>
> https://gitlab.com/libvirt/libvirt/-/merge_requests/387
>
>to add translations for the polkit files. In reviewing this we came
>to the conclusion the approach was undesirable. After getting misled
>by a Debian/Ubuntu specific downstream only patch to polkit which
>auto-translated polkit files at runtime, this implements the manual
>approach of merging translations into the polkit files at build time.
>
>Changed in v2:
>
> - Fix introduction of 'polkitactionsdir'
> - Also introduce 'polkitrulesdir'
> - Fix syntax check rules for POFILES with generated polkit
> - Remove incorrect 'install: true' rule for policy.in file
>
>Daniel P. Berrangé (3):
> po: add its rules for translating polkit file strings
> meson: remove duplication of polkit dirs construction
> remote: apply translations to polkit files
>
> build-aux/syntax-check.mk | 5 +++--
> meson.build | 6 ++++++
> po/POTFILES | 2 ++
> po/its/polkit.its | 8 ++++++++
> po/its/polkit.loc | 6 ++++++
> po/meson.build | 5 ++---
> src/access/meson.build | 20 +++++++++++++++----
> .../{libvirtd.policy => libvirtd.policy.in} | 0
> src/remote/meson.build | 15 ++++++++------
> 9 files changed, 52 insertions(+), 15 deletions(-)
> create mode 100644 po/its/polkit.its
> create mode 100644 po/its/polkit.loc
> rename src/remote/{libvirtd.policy => libvirtd.policy.in} (100%)
>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano