po: handle translatin of polkit policy file strings

[PATCH 0/2] po: handle translatin of polkit policy file strings

Daniel P. Berrangé posted 2 patches 1 year, 1 month ago

Download series mbox

Failed in applying to current master (apply log)

meson.build                                    |  5 +++++
po/POTFILES                                    |  2 ++
po/its/polkit.its                              |  8 ++++++++
po/its/polkit.loc                              |  6 ++++++
po/meson.build                                 |  3 +--
src/access/meson.build                         | 18 ++++++++++++++----
.../{libvirtd.policy => libvirtd.policy.in}    |  0
src/remote/meson.build                         | 13 ++++++++-----
8 files changed, 44 insertions(+), 11 deletions(-)
create mode 100644 po/its/polkit.its
create mode 100644 po/its/polkit.loc
rename src/remote/{libvirtd.policy => libvirtd.policy.in} (100%)

Expand all Fold all

[PATCH 0/2] po: handle translatin of polkit policy file strings

Posted by Daniel P. Berrangé 1 year, 1 month ago

There was a proposal

  https://gitlab.com/libvirt/libvirt/-/merge_requests/387

to add translations for the polkit files. In reviewing this we came
to the conclusion the approach was undesirable. After getting misled
by a Debian/Ubuntu specific downstream only patch to polkit which
auto-translated polkit files at runtime, this implements the manual
approach of merging translations into the polkit files at build time.

Daniel P. Berrangé (2):
  po: add its rules for translating polkit file strings
  remote: apply translations to polkit files

 meson.build                                    |  5 +++++
 po/POTFILES                                    |  2 ++
 po/its/polkit.its                              |  8 ++++++++
 po/its/polkit.loc                              |  6 ++++++
 po/meson.build                                 |  3 +--
 src/access/meson.build                         | 18 ++++++++++++++----
 .../{libvirtd.policy => libvirtd.policy.in}    |  0
 src/remote/meson.build                         | 13 ++++++++-----
 8 files changed, 44 insertions(+), 11 deletions(-)
 create mode 100644 po/its/polkit.its
 create mode 100644 po/its/polkit.loc
 rename src/remote/{libvirtd.policy => libvirtd.policy.in} (100%)

-- 
2.46.0

Re: [PATCH 0/2] po: handle translatin of polkit policy file strings

Posted by Ján Tomko 1 year, 1 month ago

On a Thursday in 2024, Daniel P. Berrangé wrote:
>There was a proposal
>
>  https://gitlab.com/libvirt/libvirt/-/merge_requests/387
>
>to add translations for the polkit files. In reviewing this we came
>to the conclusion the approach was undesirable. After getting misled
>by a Debian/Ubuntu specific downstream only patch to polkit which
>auto-translated polkit files at runtime, this implements the manual
>approach of merging translations into the polkit files at build time.
>
>Daniel P. Berrangé (2):
>  po: add its rules for translating polkit file strings
>  remote: apply translations to polkit files
>
> meson.build                                    |  5 +++++
> po/POTFILES                                    |  2 ++
> po/its/polkit.its                              |  8 ++++++++
> po/its/polkit.loc                              |  6 ++++++
> po/meson.build                                 |  3 +--
> src/access/meson.build                         | 18 ++++++++++++++----
> .../{libvirtd.policy => libvirtd.policy.in}    |  0
> src/remote/meson.build                         | 13 ++++++++-----
> 8 files changed, 44 insertions(+), 11 deletions(-)
> create mode 100644 po/its/polkit.its
> create mode 100644 po/its/polkit.loc
> rename src/remote/{libvirtd.policy => libvirtd.policy.in} (100%)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano