[PATCH v3 0/4] util: Change return type of functions that never fail to void

Alexander Kuznetsov posted 4 patches 5 days, 6 hours ago
src/hypervisor/virhostdev.c     | 22 ++++++++--------------
src/logging/log_daemon.c        |  8 ++------
src/logging/log_daemon_config.c |  4 +---
src/logging/log_daemon_config.h |  2 +-
src/util/virpci.c               |  4 +---
src/util/virpci.h               |  6 +++---
src/util/virscsi.c              |  4 +---
src/util/virscsi.h              |  6 +++---
src/util/virscsivhost.c         |  4 +---
src/util/virscsivhost.h         |  6 +++---
tests/virscsitest.c             |  6 ++----
11 files changed, 26 insertions(+), 46 deletions(-)
[PATCH v3 0/4] util: Change return type of functions that never fail to void
Posted by Alexander Kuznetsov 5 days, 6 hours ago
These functions return value is invariant since 18f3771, so change
its type and remove all dependent checks.

Best regards,
Alexander Kuznetsov

---
v3:
- Fix indentation errors.
- 2: add missing virSCSIDeviceSetUsedBy call
- 3: remove non-relevant cosmetic fix

v2:
- One function per commit.

Alexander Kuznetsov (4):
  util: Change return type of virPCIDeviceSetUsedBy to void
  util: Change return type of virSCSIDeviceSetUsedBy to void
  util: Change return type of virSCSIVHostDeviceSetUsedBy to void
  logging: Change return type of virLogDaemonConfigFilePat to void

 src/hypervisor/virhostdev.c     | 22 ++++++++--------------
 src/logging/log_daemon.c        |  8 ++------
 src/logging/log_daemon_config.c |  4 +---
 src/logging/log_daemon_config.h |  2 +-
 src/util/virpci.c               |  4 +---
 src/util/virpci.h               |  6 +++---
 src/util/virscsi.c              |  4 +---
 src/util/virscsi.h              |  6 +++---
 src/util/virscsivhost.c         |  4 +---
 src/util/virscsivhost.h         |  6 +++---
 tests/virscsitest.c             |  6 ++----
 11 files changed, 26 insertions(+), 46 deletions(-)

-- 
2.42.2
Re: [PATCH v3 0/4] util: Change return type of functions that never fail to void
Posted by Jiri Denemark 5 days, 5 hours ago
On Mon, Dec 16, 2024 at 12:41:04 +0300, Alexander Kuznetsov wrote:
> These functions return value is invariant since 18f3771, so change
> its type and remove all dependent checks.
> 
> Best regards,
> Alexander Kuznetsov
> 
> ---
> v3:
> - Fix indentation errors.
> - 2: add missing virSCSIDeviceSetUsedBy call
> - 3: remove non-relevant cosmetic fix
> 
> v2:
> - One function per commit.
> 
> Alexander Kuznetsov (4):
>   util: Change return type of virPCIDeviceSetUsedBy to void
>   util: Change return type of virSCSIDeviceSetUsedBy to void
>   util: Change return type of virSCSIVHostDeviceSetUsedBy to void
>   logging: Change return type of virLogDaemonConfigFilePat to void
> 
>  src/hypervisor/virhostdev.c     | 22 ++++++++--------------
>  src/logging/log_daemon.c        |  8 ++------
>  src/logging/log_daemon_config.c |  4 +---
>  src/logging/log_daemon_config.h |  2 +-
>  src/util/virpci.c               |  4 +---
>  src/util/virpci.h               |  6 +++---
>  src/util/virscsi.c              |  4 +---
>  src/util/virscsi.h              |  6 +++---
>  src/util/virscsivhost.c         |  4 +---
>  src/util/virscsivhost.h         |  6 +++---
>  tests/virscsitest.c             |  6 ++----
>  11 files changed, 26 insertions(+), 46 deletions(-)

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>

and pushed. Thanks.