[PATCH v2 0/6] Change return type of functions that use VIR_EXPAND_N and never fail to void

Alexander Kuznetsov posted 6 patches 3 weeks, 2 days ago
src/access/viraccessdriverstack.c |  4 +---
src/access/viraccessdriverstack.h |  2 +-
src/access/viraccessmanager.c     |  5 +----
src/admin/admin_remote.c          |  3 +--
src/hyperv/hyperv_wmi.c           | 13 ++++-------
src/locking/lock_daemon.c         | 10 ++-------
src/locking/lock_driver_lockd.c   |  3 +--
src/logging/log_daemon.c          | 10 ++-------
src/logging/log_manager.c         |  3 +--
src/lxc/lxc_monitor.c             |  4 +---
src/remote/remote_daemon.c        | 20 ++++-------------
src/remote/remote_driver.c        | 17 +++++----------
src/rpc/gendispatch.pl            |  5 +----
src/rpc/virnetclient.c            |  6 ++----
src/rpc/virnetclient.h            |  4 ++--
src/rpc/virnetserver.c            |  3 +--
src/rpc/virnetserver.h            |  2 +-
src/util/virsysinfo.c             | 36 +++++++++++--------------------
18 files changed, 43 insertions(+), 107 deletions(-)
[PATCH v2 0/6] Change return type of functions that use VIR_EXPAND_N and never fail to void
Posted by Alexander Kuznetsov 3 weeks, 2 days ago
These functions return value is invariant since VIR_EXPAND_N check
removal in 7d2fd6e, so change its type and remove all dependent checks.

Best regards,
Alexander Kuznetsov

---
v2:
- One function/file per commit.

Alexander Kuznetsov (6):
  access: Change return type of virAccessDriverStackAppend to void
  rpc: Change return type of virNetServerAddProgram to void
  rpc: Change return type of virNetClientAddProgram to void
  rpc: Change return type of virNetClientAddStream to void
  hyperv: Change return type of hypervCheckParams to void
  util: virsysinfo: Change return type of functions that never fail to
    void

 src/access/viraccessdriverstack.c |  4 +---
 src/access/viraccessdriverstack.h |  2 +-
 src/access/viraccessmanager.c     |  5 +----
 src/admin/admin_remote.c          |  3 +--
 src/hyperv/hyperv_wmi.c           | 13 ++++-------
 src/locking/lock_daemon.c         | 10 ++-------
 src/locking/lock_driver_lockd.c   |  3 +--
 src/logging/log_daemon.c          | 10 ++-------
 src/logging/log_manager.c         |  3 +--
 src/lxc/lxc_monitor.c             |  4 +---
 src/remote/remote_daemon.c        | 20 ++++-------------
 src/remote/remote_driver.c        | 17 +++++----------
 src/rpc/gendispatch.pl            |  5 +----
 src/rpc/virnetclient.c            |  6 ++----
 src/rpc/virnetclient.h            |  4 ++--
 src/rpc/virnetserver.c            |  3 +--
 src/rpc/virnetserver.h            |  2 +-
 src/util/virsysinfo.c             | 36 +++++++++++--------------------
 18 files changed, 43 insertions(+), 107 deletions(-)

-- 
2.42.2
Re: [PATCH v2 0/6] Change return type of functions that use VIR_EXPAND_N and never fail to void
Posted by Alexander Kuznetsov 1 week, 1 day ago
Submit patches guideline recommends to ping if there is no response for more than a week,
so I kindly remind about these cosmetic fixes too :)
Re: [PATCH v2 0/6] Change return type of functions that use VIR_EXPAND_N and never fail to void
Posted by Jiri Denemark 1 week, 1 day ago
On Fri, Dec 13, 2024 at 13:59:26 -0000, Alexander Kuznetsov wrote:
> Submit patches guideline recommends to ping if there is no response for more than a week,
> so I kindly remind about these cosmetic fixes too :)

I fixed the indentation issues and pushed the series. Thanks.

Jirka