1. Patchew
  2. Libvirt
  3. [PATCH v5 00/18] *** qemu: block: Support block disk along with throttle filters ***
  4. View patch

[PATCH v5 02/18] schema: Add new domain elements to support multiple throttle filters

Harikumar R posted 18 patches 1 year, 2 months ago
There is a newer version of this series
[PATCH v5 02/18] schema: Add new domain elements to support multiple throttle filters
Posted by Harikumar R 1 year, 2 months ago 
From: Chun Feng Wu <danielwuwy@163.com>

Introduce schema for defining '<throttlefilters>' element which
references throttling groups to form filter chain in qemu for specific
disk

* Add new elements '<throttlefilters>'
* <ThrottleFilters> can include multiple throttlegroup references to
  form filter chain in qemu
* Chained throttle filters feature in qemu is described at
  https://github.com/qemu/qemu/blob/master/docs/throttle.txt

Signed-off-by: Chun Feng Wu <danielwuwy@163.com>
---
 docs/formatdomain.rst             | 21 +++++++++++++++++++++
 src/conf/schemas/domaincommon.rng | 19 ++++++++++++++++++-
 2 files changed, 39 insertions(+), 1 deletion(-)

diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index 5b7f18b2f0..0c41b47a77 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -2753,6 +2753,15 @@ paravirtualized driver is specified via the ``disk`` element.
        <source dev='/dev/vhost-vdpa-0' />
        <target dev='vdg' bus='virtio'/>
      </disk>
+     <disk type='file' device='disk'>
+       <driver name='qemu' type='qcow2' />
+       <source file='/var/lib/libvirt/images/disk.qcow2'/>
+       <target dev='vdh' bus='virtio'/>
+       <throttlefilters>
+         <throttlefilter group='limit2'/>
+         <throttlefilter group='limit012'/>
+       </throttlefilters>
+     </disk>
    </devices>
    ...
 
@@ -3233,6 +3242,18 @@ paravirtualized driver is specified via the ``disk`` element.
    :since:`since after 0.4.4`; "sata" attribute value :since:`since 0.9.7`;
    "removable" attribute value :since:`since 1.1.3`;
    "rotation_rate" attribute value :since:`since 7.3.0`
+``throttlefilters``
+   The optional ``throttlefilters`` element provides the ability to provide additional
+   per-device throttle chain :since:`Since 10.7.0`
+   For example, if we have four different disks and we want to limit I/O for each one
+   and we also want to limit combined I/O of all four disks, we can leverage
+   ``throttlefilters`` to achieve this goal by setting two ``throttlefilter`` for
+   each disk: disk's own filter(e.g. limit2) and combined filter(e.g. limit012).
+   The order of such ``throttlefilter`` doesn't matter within ``throttlefilters``.
+   ``throttlefilters`` and ``iotune`` should be used exclusively.
+
+   ``throttlefilter``
+      The optional ``throttlefilter`` element is to reference defined throttle group.
 ``iotune``
    The optional ``iotune`` element provides the ability to provide additional
    per-device I/O tuning, with values that can vary for each device (contrast
diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincommon.rng
index 6f08ac4da5..131fd396a4 100644
--- a/src/conf/schemas/domaincommon.rng
+++ b/src/conf/schemas/domaincommon.rng
@@ -1636,7 +1636,10 @@
         <ref name="encryption"/>
       </optional>
       <optional>
-        <ref name="diskIoTune"/>
+        <choice>
+          <ref name="throttlefilters"/>
+          <ref name="diskIoTune"/>
+        </choice>
       </optional>
       <optional>
         <ref name="alias"/>
@@ -6840,6 +6843,20 @@
       </element>
     </optional>
   </define>
+  <!--
+      A set of throttlefilters to reference throttlegroups
+    -->
+  <define name="throttlefilters">
+    <element name="throttlefilters">
+      <zeroOrMore>
+        <element name="throttlefilter">
+          <attribute name="group">
+            <data type="string"/>
+          </attribute>
+        </element>
+      </zeroOrMore>
+    </element>
+  </define>
   <!--
       A set of optional features: PAE, APIC, ACPI, GIC, TCG,
       HyperV Enlightenment, KVM features, paravirtual spinlocks and HAP support
-- 
2.39.5 (Apple Git-154)
Re: [PATCH v5 02/18] schema: Add new domain elements to support multiple throttle filters
Posted by Peter Krempa 1 year, 2 months ago 
On Mon, Nov 18, 2024 at 19:24:10 +0530, Harikumar R wrote:
> From: Chun Feng Wu <danielwuwy@163.com>
> 
> Introduce schema for defining '<throttlefilters>' element which
> references throttling groups to form filter chain in qemu for specific
> disk
> 
> * Add new elements '<throttlefilters>'
> * <ThrottleFilters> can include multiple throttlegroup references to
>   form filter chain in qemu
> * Chained throttle filters feature in qemu is described at
>   https://github.com/qemu/qemu/blob/master/docs/throttle.txt

qemu uses gitlab as main project forge so

 https://gitlab.com/qemu-project/qemu/ ... 

> 
> Signed-off-by: Chun Feng Wu <danielwuwy@163.com>
> ---
>  docs/formatdomain.rst             | 21 +++++++++++++++++++++
>  src/conf/schemas/domaincommon.rng | 19 ++++++++++++++++++-
>  2 files changed, 39 insertions(+), 1 deletion(-)
> 
> diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
> index 5b7f18b2f0..0c41b47a77 100644
> --- a/docs/formatdomain.rst
> +++ b/docs/formatdomain.rst
> @@ -2753,6 +2753,15 @@ paravirtualized driver is specified via the ``disk`` element.
>         <source dev='/dev/vhost-vdpa-0' />
>         <target dev='vdg' bus='virtio'/>
>       </disk>
> +     <disk type='file' device='disk'>
> +       <driver name='qemu' type='qcow2' />
> +       <source file='/var/lib/libvirt/images/disk.qcow2'/>
> +       <target dev='vdh' bus='virtio'/>

This had a rebase conflict as another example was added recently, don't
forget to bump to 'vdg' when resovling the conflict.

> +       <throttlefilters>
> +         <throttlefilter group='limit2'/>
> +         <throttlefilter group='limit012'/>
> +       </throttlefilters>
> +     </disk>
>     </devices>
>     ...
>  
> @@ -3233,6 +3242,18 @@ paravirtualized driver is specified via the ``disk`` element.
>     :since:`since after 0.4.4`; "sata" attribute value :since:`since 0.9.7`;
>     "removable" attribute value :since:`since 1.1.3`;
>     "rotation_rate" attribute value :since:`since 7.3.0`
> +``throttlefilters``
> +   The optional ``throttlefilters`` element provides the ability to provide additional
> +   per-device throttle chain :since:`Since 10.7.0`

11.0.0

> +   For example, if we have four different disks and we want to limit I/O for each one
> +   and we also want to limit combined I/O of all four disks, we can leverage
> +   ``throttlefilters`` to achieve this goal by setting two ``throttlefilter`` for
> +   each disk: disk's own filter(e.g. limit2) and combined filter(e.g. limit012).
> +   The order of such ``throttlefilter`` doesn't matter within ``throttlefilters``.
> +   ``throttlefilters`` and ``iotune`` should be used exclusively.
> +
> +   ``throttlefilter``
> +      The optional ``throttlefilter`` element is to reference defined throttle group.
>  ``iotune``
>     The optional ``iotune`` element provides the ability to provide additional
>     per-device I/O tuning, with values that can vary for each device (contrast

Reviewed-by: Peter Krempa <pkrempa@redhat.com>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.