*** BLURB HERE ***

Chun Feng Wu (17):
  schema: Add new domain elements to support multiple throttle groups
  schema: Add new domain elements to support multiple throttle filters
  config: Introduce ThrottleGroup and corresponding XML parsing
  config: Introduce ThrottleFilter and corresponding XML parsing
  qemu: monitor: Add support for ThrottleGroup operations
  tests: Test qemuMonitorJSONGetThrottleGroup and
    qemuMonitorJSONUpdateThrottleGroup
  remote: New APIs for ThrottleGroup lifecycle management
  qemu: Refactor qemuDomainSetBlockIoTune to extract common methods
  qemu: Implement qemu driver for throttle API
  qemu: helper: throttle filter nodename and preparation processing
  qemu: block: Support block disk along with throttle filters
  config: validate: Verify iotune, throttle group and filter
  qemuxmlconftest: Add 'throttlefilter' tests
  test_driver: Test throttle group lifecycle APIs
  virsh: Refactor iotune options for re-use
  virsh: Add support for throttle group operations
  virsh: Add option "throttle-groups" to "attach_disk"

Harikumar Rajkumar (1):
  tests: Test qemuxmlactivetestThrottleGroup

 docs/formatdomain.rst                         |  47 ++
 docs/manpages/virsh.rst                       | 135 +++-
 include/libvirt/libvirt-domain.h              |  21 +
 src/conf/domain_conf.c                        | 398 ++++++++++
 src/conf/domain_conf.h                        |  45 ++
 src/conf/domain_validate.c                    | 119 ++-
 src/conf/schemas/domaincommon.rng             | 293 ++++----
 src/conf/virconftypes.h                       |   4 +
 src/driver-hypervisor.h                       |  22 +
 src/libvirt-domain.c                          | 174 +++++
 src/libvirt_private.syms                      |   8 +
 src/libvirt_public.syms                       |   7 +
 src/qemu/qemu_block.c                         | 136 ++++
 src/qemu/qemu_block.h                         |  49 ++
 src/qemu/qemu_command.c                       | 180 +++++
 src/qemu/qemu_command.h                       |   6 +
 src/qemu/qemu_domain.c                        |  73 +-
 src/qemu/qemu_driver.c                        | 619 +++++++++++++---
 src/qemu/qemu_hotplug.c                       |  33 +
 src/qemu/qemu_monitor.c                       |  34 +
 src/qemu/qemu_monitor.h                       |  14 +
 src/qemu/qemu_monitor_json.c                  | 134 ++++
 src/qemu/qemu_monitor_json.h                  |  14 +
 src/remote/remote_daemon_dispatch.c           |  44 ++
 src/remote/remote_driver.c                    |  40 ++
 src/remote/remote_protocol.x                  |  48 +-
 src/remote_protocol-structs                   |  28 +
 src/test/test_driver.c                        | 452 ++++++++----
 tests/qemumonitorjsontest.c                   |  86 +++
 .../throttlefilter-in.xml                     | 392 ++++++++++
 .../throttlefilter-out.xml                    | 393 ++++++++++
 tests/qemuxmlactivetest.c                     |   1 +
 .../throttlefilter-invalid.x86_64-latest.err  |   1 +
 .../throttlefilter-invalid.xml                |  89 +++
 .../throttlefilter.x86_64-latest.args         |  55 ++
 .../throttlefilter.x86_64-latest.xml          | 105 +++
 tests/qemuxmlconfdata/throttlefilter.xml      |  95 +++
 tests/qemuxmlconftest.c                       |   2 +
 tools/virsh-completer-domain.c                |  82 +++
 tools/virsh-completer-domain.h                |  16 +
 tools/virsh-domain.c                          | 680 ++++++++++++++----
 41 files changed, 4649 insertions(+), 525 deletions(-)
 create mode 100644 tests/qemustatusxml2xmldata/throttlefilter-in.xml
 create mode 100644 tests/qemustatusxml2xmldata/throttlefilter-out.xml
 create mode 100644 tests/qemuxmlconfdata/throttlefilter-invalid.x86_64-latest.err
 create mode 100644 tests/qemuxmlconfdata/throttlefilter-invalid.xml
 create mode 100644 tests/qemuxmlconfdata/throttlefilter.x86_64-latest.args
 create mode 100644 tests/qemuxmlconfdata/throttlefilter.x86_64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/throttlefilter.xml

-- 
2.39.5 (Apple Git-154)

Hi Peter Krempa, Could you please prioritize reviews for remaining commits so we can create new patch request with all fix. We have a requirement which depends on this change and we are currently blocked.

On Wed, Jan 22, 2025 at 07:37:22 -0000, Harikumar Rajkumar wrote:
> Hi Peter Krempa, Could you please prioritize reviews for remaining commits so we can create new patch request with all fix. We have a requirement which depends on this change and we are currently blocked.
> 

Please refer to my previous reply:

https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/7BLZEH4O6QAGX7V63BZQAMBXYWZB4WON/

On Mon, Nov 18, 2024 at 19:24:08 +0530, Harikumar R wrote:
> *** BLURB HERE ***
> 
> Chun Feng Wu (17):
>   schema: Add new domain elements to support multiple throttle groups
>   schema: Add new domain elements to support multiple throttle filters
>   config: Introduce ThrottleGroup and corresponding XML parsing
>   config: Introduce ThrottleFilter and corresponding XML parsing
>   qemu: monitor: Add support for ThrottleGroup operations
>   tests: Test qemuMonitorJSONGetThrottleGroup and
>     qemuMonitorJSONUpdateThrottleGroup
>   remote: New APIs for ThrottleGroup lifecycle management
>   qemu: Refactor qemuDomainSetBlockIoTune to extract common methods
>   qemu: Implement qemu driver for throttle API
>   qemu: helper: throttle filter nodename and preparation processing
>   qemu: block: Support block disk along with throttle filters
>   config: validate: Verify iotune, throttle group and filter
>   qemuxmlconftest: Add 'throttlefilter' tests
>   test_driver: Test throttle group lifecycle APIs
>   virsh: Refactor iotune options for re-use
>   virsh: Add support for throttle group operations
>   virsh: Add option "throttle-groups" to "attach_disk"
> 
> Harikumar Rajkumar (1):
>   tests: Test qemuxmlactivetestThrottleGroup

The review is done now. There are few bits.

Please note that I didn't point out *all* places needing a version
number update, so make sure to check everything explicitly. Please use
11.1.0 for next posting.

One important bit is that IMO the getter API makes IMO no sense to be
added as the data can simply be queried from the XML. Having a special
API is a bit overkill.

Few other things I've pointed out:
 - some coding style issues
 - some pointless comments

> On Mon, Nov 18, 2024 at 19:24:08 +0530, Harikumar R wrote:
> 
> The review is done now. There are few bits.
> 
> Please note that I didn't point out *all* places needing a version
> number update, so make sure to check everything explicitly. Please use
> 11.1.0 for next posting.
> 
> One important bit is that IMO the getter API makes IMO no sense to be
> added as the data can simply be queried from the XML. Having a special
> API is a bit overkill.
> 
> Few other things I've pointed out:
>  - some coding style issues
>  - some pointless comments

I have addressed the feedbacks and submitted new patch version 7.
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/TV3HJ74I5CTDUHKZTDLF2VKEKACSDTHR/

Hi Peter Krempa, any ETA to complete this patch request?

On Mon, Jan 06, 2025 at 10:45:16 -0000, harirajkumar230@gmail.com wrote:
> Hi Peter Krempa, any ETA to complete this patch request?

I'm sorry. As I've noted multiple times due to personal reasons my work
capacity is limited.  I can't give you an ETA.

As you seem to be only keen to get this feature merged and don't seem to
get involved more widely into the project in other ways besides adding
this feature. I'm thus expecting that the maintenance of this feature will be
inherited by the maintainers of the project (-> e.g. me in this case).

Thus please understand, that this is non-trivial amount of code, the
feature itself is not likely going to be widely used and the maintenance will
most likely fall on my shoulders in the long term. Thus it's not exactly
high on my priority list.

I'm sorry but that is the reality of things.