[PATCH] spec: Drop nwfilter dependency in libvirt-daemon-xen

Jim Fehlig via Devel posted 1 patch 1 year, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20241021205745.14760-1-jfehlig@suse.com
libvirt.spec.in | 1 -
1 file changed, 1 deletion(-)
[PATCH] spec: Drop nwfilter dependency in libvirt-daemon-xen
Posted by Jim Fehlig via Devel 1 year, 3 months ago
The libvirt xen driver does not support nwfilters. In fact, since
commit d721b6840f, the driver rejects VM configuration referencing
nwfilters. Drop the needless nwfilter dependency from
libvirt-daemon-xen.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
---
 libvirt.spec.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index f26de04553..d54d2a1e3e 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -993,7 +993,6 @@ Requires: libvirt-daemon-driver-libxl = %{version}-%{release}
 Requires: libvirt-daemon-driver-interface = %{version}-%{release}
 Requires: libvirt-daemon-driver-network = %{version}-%{release}
 Requires: libvirt-daemon-driver-nodedev = %{version}-%{release}
-Requires: libvirt-daemon-driver-nwfilter = %{version}-%{release}
 Requires: libvirt-daemon-driver-secret = %{version}-%{release}
 Requires: libvirt-daemon-driver-storage = %{version}-%{release}
 Requires: xen
-- 
2.43.0
Re: [PATCH] spec: Drop nwfilter dependency in libvirt-daemon-xen
Posted by Laine Stump 1 year, 3 months ago
On 10/21/24 4:57 PM, Jim Fehlig via Devel wrote:
> The libvirt xen driver does not support nwfilters. In fact, since
> commit d721b6840f, the driver rejects VM configuration referencing
> nwfilters. Drop the needless nwfilter dependency from
> libvirt-daemon-xen.
> 
> Signed-off-by: Jim Fehlig <jfehlig@suse.com>

Reviewed-by: Laine Stump <Laine@redhat.com>
> ---
>   libvirt.spec.in | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index f26de04553..d54d2a1e3e 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -993,7 +993,6 @@ Requires: libvirt-daemon-driver-libxl = %{version}-%{release}
>   Requires: libvirt-daemon-driver-interface = %{version}-%{release}
>   Requires: libvirt-daemon-driver-network = %{version}-%{release}
>   Requires: libvirt-daemon-driver-nodedev = %{version}-%{release}
> -Requires: libvirt-daemon-driver-nwfilter = %{version}-%{release}
>   Requires: libvirt-daemon-driver-secret = %{version}-%{release}
>   Requires: libvirt-daemon-driver-storage = %{version}-%{release}
>   Requires: xen