[PATCH v2 0/1] Add support for RAPL MSRs feature in QEMU

Anthony Harivel posted 1 patch 3 months ago
docs/formatdomain.rst                          |  2 ++
src/conf/domain_conf.c                         | 18 ++++++++++++++++++
src/conf/domain_conf.h                         |  2 ++
src/conf/schemas/domaincommon.rng              | 10 ++++++++++
src/qemu/qemu_command.c                        | 11 +++++++++++
tests/qemuxmlconfdata/kvm-features-off.xml     |  1 +
.../kvm-features.x86_64-latest.args            |  2 +-
tests/qemuxmlconfdata/kvm-features.xml         |  1 +
8 files changed, 46 insertions(+), 1 deletion(-)
[PATCH v2 0/1] Add support for RAPL MSRs feature in QEMU
Posted by Anthony Harivel 3 months ago
Hi,

First of all, kudos to Peter Krempa for his fast review!

In this v2, I've addressed the following points:

- The socket is *not* mandatory and my code totally confused Peter. 
  Sorry about that! 

  here a snippet of the QEMU code to understand:

  /* Compute the socket path if necessary */
  if (s->msr_energy.socket_path == NULL) {
       s->msr_energy.socket_path = vmsr_compute_default_paths();
  }

  So I made all the modification to make it not necessary.

- Change the socket name to "rapl_helper_socket"
- Change the socket to be absFilePath
- I did not add anything to honour the _OFF state, because it is not 
  necessary to explicitly disable it. 

That's about it. 

Regards,
Anthony

Anthony Harivel (1):
  qemu: Add support for RAPL MSRs feature

 docs/formatdomain.rst                          |  2 ++
 src/conf/domain_conf.c                         | 18 ++++++++++++++++++
 src/conf/domain_conf.h                         |  2 ++
 src/conf/schemas/domaincommon.rng              | 10 ++++++++++
 src/qemu/qemu_command.c                        | 11 +++++++++++
 tests/qemuxmlconfdata/kvm-features-off.xml     |  1 +
 .../kvm-features.x86_64-latest.args            |  2 +-
 tests/qemuxmlconfdata/kvm-features.xml         |  1 +
 8 files changed, 46 insertions(+), 1 deletion(-)

-- 
2.46.0