[PATCH V2 0/2] qemu: Clarify purpose of image format settings

Jim Fehlig via Devel posted 2 patches 3 months, 1 week ago
src/qemu/qemu.conf.in     | 40 +++++++++++++++++++++++----------------
src/qemu/qemu_driver.c    | 30 ++++++++++++++---------------
src/qemu/qemu_saveimage.c | 32 +++++++++++++++----------------
src/qemu/qemu_saveimage.h |  4 ++--
src/qemu/qemu_snapshot.c  |  6 +++---
5 files changed, 60 insertions(+), 52 deletions(-)
[PATCH V2 0/2] qemu: Clarify purpose of image format settings
Posted by Jim Fehlig via Devel 3 months, 1 week ago
The current documentation of the various foo_image_format settings in
qemu.conf subtly implies they are only used for specifying compression.
Patch1 of this small series attempts to clarify and improve the description
of the settings. It defines image format as a way to specify the desired
layout of guest memory blocks on disk.

Patch2 changes the use of 'compressed' with 'format' throughout the
code, removing implication that format == compressed.

V2:
Replace more uses of 'compressed' with 'format' in patch2

Jim Fehlig (2):
  qemu: conf: Improve the foo_image_format setting descriptions
  qemu: Use consistent naming for save image format

 src/qemu/qemu.conf.in     | 40 +++++++++++++++++++++++----------------
 src/qemu/qemu_driver.c    | 30 ++++++++++++++---------------
 src/qemu/qemu_saveimage.c | 32 +++++++++++++++----------------
 src/qemu/qemu_saveimage.h |  4 ++--
 src/qemu/qemu_snapshot.c  |  6 +++---
 5 files changed, 60 insertions(+), 52 deletions(-)

-- 
2.35.3
Re: [PATCH V2 0/2] qemu: Clarify purpose of image format settings
Posted by Jim Fehlig via Devel 2 months, 3 weeks ago
Hi All,

Any comments on this idea? Recall the motivation for this change is to 
subsequently use the image format settings to request mapped-ram.

Regards,
Jim

On 8/16/24 16:25, Jim Fehlig wrote:
> The current documentation of the various foo_image_format settings in
> qemu.conf subtly implies they are only used for specifying compression.
> Patch1 of this small series attempts to clarify and improve the description
> of the settings. It defines image format as a way to specify the desired
> layout of guest memory blocks on disk.
> 
> Patch2 changes the use of 'compressed' with 'format' throughout the
> code, removing implication that format == compressed.
> 
> V2:
> Replace more uses of 'compressed' with 'format' in patch2
> 
> Jim Fehlig (2):
>    qemu: conf: Improve the foo_image_format setting descriptions
>    qemu: Use consistent naming for save image format
> 
>   src/qemu/qemu.conf.in     | 40 +++++++++++++++++++++++----------------
>   src/qemu/qemu_driver.c    | 30 ++++++++++++++---------------
>   src/qemu/qemu_saveimage.c | 32 +++++++++++++++----------------
>   src/qemu/qemu_saveimage.h |  4 ++--
>   src/qemu/qemu_snapshot.c  |  6 +++---
>   5 files changed, 60 insertions(+), 52 deletions(-)
>