[PATCH 0/2] qemu: Clarify purpose of image format settings

Jim Fehlig via Devel posted 2 patches 3 months, 1 week ago
There is a newer version of this series
src/qemu/qemu.conf.in     | 46 +++++++++++++++++++++++++--------------
src/qemu/qemu_saveimage.c | 18 +++++++--------
src/qemu/qemu_saveimage.h |  4 ++--
3 files changed, 41 insertions(+), 27 deletions(-)
[PATCH 0/2] qemu: Clarify purpose of image format settings
Posted by Jim Fehlig via Devel 3 months, 1 week ago
The current documentation of the various foo_image_format settings in
qemu.conf subtly implies they are only used for specifying compression.
Patch1 of this small series attempts to clarify and improve the description
of the settings. It defines image format as a way to specify the desired
layout of guest memory blocks on disk.

Patch2 changes the name of the 'compressed' field of virQEMUSaveHeader to
'format', removing implication that format == compressed in the code.

Jim Fehlig (2):
  qemu: conf: Improve the foo_image_format setting descriptions
  qemu: Rename compressed field of save image header

 src/qemu/qemu.conf.in     | 46 +++++++++++++++++++++++++--------------
 src/qemu/qemu_saveimage.c | 18 +++++++--------
 src/qemu/qemu_saveimage.h |  4 ++--
 3 files changed, 41 insertions(+), 27 deletions(-)

-- 
2.35.3
Re: [PATCH 0/2] qemu: Clarify purpose of image format settings
Posted by Jim Fehlig via Devel 3 months, 1 week ago
On 8/16/24 11:20, Jim Fehlig wrote:
> The current documentation of the various foo_image_format settings in
> qemu.conf subtly implies they are only used for specifying compression.
> Patch1 of this small series attempts to clarify and improve the description
> of the settings. It defines image format as a way to specify the desired
> layout of guest memory blocks on disk.
> 
> Patch2 changes the name of the 'compressed' field of virQEMUSaveHeader to
> 'format', removing implication that format == compressed in the code.

This patch could have went a bit further in replacing the use of 'compressed' 
with 'format'. I've sent a V2 of the series

https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/ROTXTO3ZDOJB7T6YLCQP7KHZYPL725LT/

Regards,
Jim