Enable NAT network support for ch guests

[PATCH 0/2] Enable NAT network support for ch guests

Posted by Praveen K Paladugu 3 months, 3 weeks ago

Move additional domain interface management methods to hypervisor
and enable NAT mode network support for ch guests.

Praveen K Paladugu (2):
  hypervisor: Move domain interface mgmt methods
  ch: Enable NAT Network mode support

 src/ch/ch_interface.c             |  57 ++++++--
 src/hypervisor/domain_interface.c | 228 ++++++++++++++++++++++++++++++
 src/hypervisor/domain_interface.h |  10 ++
 src/libvirt_private.syms          |   1 +
 src/qemu/qemu_command.c           |   9 +-
 src/qemu/qemu_interface.c         | 219 +---------------------------
 6 files changed, 289 insertions(+), 235 deletions(-)

-- 
2.44.0

Re: [PATCH 0/2] Enable NAT network support for ch guests

Posted by Michal Prívozník 2 months, 4 weeks ago

On 8/2/24 00:25, Praveen K Paladugu wrote:
> Move additional domain interface management methods to hypervisor
> and enable NAT mode network support for ch guests.
> 
> Praveen K Paladugu (2):
>   hypervisor: Move domain interface mgmt methods
>   ch: Enable NAT Network mode support
> 
>  src/ch/ch_interface.c             |  57 ++++++--
>  src/hypervisor/domain_interface.c | 228 ++++++++++++++++++++++++++++++
>  src/hypervisor/domain_interface.h |  10 ++
>  src/libvirt_private.syms          |   1 +
>  src/qemu/qemu_command.c           |   9 +-
>  src/qemu/qemu_interface.c         | 219 +---------------------------
>  6 files changed, 289 insertions(+), 235 deletions(-)
> 

I'm fixing all the small nits I've found and merging.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

Re: [PATCH 0/2] Enable NAT network support for ch guests

Posted by Praveen K Paladugu 2 months, 4 weeks ago

Thanks Michal!!

On 8/26/2024 9:15 AM, Michal Prívozník wrote:
> On 8/2/24 00:25, Praveen K Paladugu wrote:
>> Move additional domain interface management methods to hypervisor
>> and enable NAT mode network support for ch guests.
>>
>> Praveen K Paladugu (2):
>>    hypervisor: Move domain interface mgmt methods
>>    ch: Enable NAT Network mode support
>>
>>   src/ch/ch_interface.c             |  57 ++++++--
>>   src/hypervisor/domain_interface.c | 228 ++++++++++++++++++++++++++++++
>>   src/hypervisor/domain_interface.h |  10 ++
>>   src/libvirt_private.syms          |   1 +
>>   src/qemu/qemu_command.c           |   9 +-
>>   src/qemu/qemu_interface.c         | 219 +---------------------------
>>   6 files changed, 289 insertions(+), 235 deletions(-)
>>
> 
> I'm fixing all the small nits I've found and merging.
> 
> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
> 
> Michal
> 

-- 
Regards,
Praveen K Paladugu

Re: [PATCH 0/2] Enable NAT network support for ch guests

Posted by Praveen K Paladugu 3 months ago

Bubbling up this thread for reviews.


On 8/1/2024 5:25 PM, Praveen K Paladugu wrote:
> Move additional domain interface management methods to hypervisor
> and enable NAT mode network support for ch guests.
> 
> Praveen K Paladugu (2):
>    hypervisor: Move domain interface mgmt methods
>    ch: Enable NAT Network mode support
> 
>   src/ch/ch_interface.c             |  57 ++++++--
>   src/hypervisor/domain_interface.c | 228 ++++++++++++++++++++++++++++++
>   src/hypervisor/domain_interface.h |  10 ++
>   src/libvirt_private.syms          |   1 +
>   src/qemu/qemu_command.c           |   9 +-
>   src/qemu/qemu_interface.c         | 219 +---------------------------
>   6 files changed, 289 insertions(+), 235 deletions(-)
> 

-- 
Regards,
Praveen K Paladugu