[PATCH 0/4] Rework qemu internal active snapshots to use QMP

Nikolai Barybin via Devel posted 4 patches 1 month, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20240715225013.100847-2-nikolai.barybin@virtuozzo.com
There is a newer version of this series
po/POTFILES                  |   1 -
po/libvirt.pot               |  18 ----
src/qemu/meson.build         |   1 -
src/qemu/qemu_block.c        |   2 +
src/qemu/qemu_blockjob.c     |   6 +-
src/qemu/qemu_blockjob.h     |   2 +
src/qemu/qemu_domain.c       |   4 +
src/qemu/qemu_monitor.c      |  23 +++--
src/qemu/qemu_monitor.h      |  16 +++-
src/qemu/qemu_monitor_json.c |  66 +++++++++++++++
src/qemu/qemu_monitor_json.h |  13 +++
src/qemu/qemu_monitor_text.c |  88 -------------------
src/qemu/qemu_monitor_text.h |  29 -------
src/qemu/qemu_snapshot.c     | 158 ++++++++++++++++++++++++++++++++---
14 files changed, 267 insertions(+), 160 deletions(-)
delete mode 100644 src/qemu/qemu_monitor_text.c
delete mode 100644 src/qemu/qemu_monitor_text.h
[PATCH 0/4] Rework qemu internal active snapshots to use QMP
Posted by Nikolai Barybin via Devel 1 month, 3 weeks ago
These patches make use of QMP recently added snapshot-save/delete
commands and reaps HMP savevm/deletevm. The usage of HMP commands
are highly discouraged by QEMU.

Nikolai Barybin (4):
  qemu monitor: add snaphot-save/delete QMP commands
  qemu blockjob: add snapshot-save/delete job types
  qemu snapshot: use QMP snapshot-save/delete for internal snapshots
  qemu monitor: reap qemu_monitor_text

 po/POTFILES                  |   1 -
 po/libvirt.pot               |  18 ----
 src/qemu/meson.build         |   1 -
 src/qemu/qemu_block.c        |   2 +
 src/qemu/qemu_blockjob.c     |   6 +-
 src/qemu/qemu_blockjob.h     |   2 +
 src/qemu/qemu_domain.c       |   4 +
 src/qemu/qemu_monitor.c      |  23 +++--
 src/qemu/qemu_monitor.h      |  16 +++-
 src/qemu/qemu_monitor_json.c |  66 +++++++++++++++
 src/qemu/qemu_monitor_json.h |  13 +++
 src/qemu/qemu_monitor_text.c |  88 -------------------
 src/qemu/qemu_monitor_text.h |  29 -------
 src/qemu/qemu_snapshot.c     | 158 ++++++++++++++++++++++++++++++++---
 14 files changed, 267 insertions(+), 160 deletions(-)
 delete mode 100644 src/qemu/qemu_monitor_text.c
 delete mode 100644 src/qemu/qemu_monitor_text.h

-- 
2.43.5
Re: [PATCH 0/4] Rework qemu internal active snapshots to use QMP
Posted by Nikolai Barybin via Devel 1 month, 1 week ago
Hello everyone! This is a ping email

On 7/16/24 00:42, Nikolai Barybin wrote:
> These patches make use of QMP recently added snapshot-save/delete
> commands and reaps HMP savevm/deletevm. The usage of HMP commands
> are highly discouraged by QEMU.
>
> Nikolai Barybin (4):
>    qemu monitor: add snaphot-save/delete QMP commands
>    qemu blockjob: add snapshot-save/delete job types
>    qemu snapshot: use QMP snapshot-save/delete for internal snapshots
>    qemu monitor: reap qemu_monitor_text
>
>   po/POTFILES                  |   1 -
>   po/libvirt.pot               |  18 ----
>   src/qemu/meson.build         |   1 -
>   src/qemu/qemu_block.c        |   2 +
>   src/qemu/qemu_blockjob.c     |   6 +-
>   src/qemu/qemu_blockjob.h     |   2 +
>   src/qemu/qemu_domain.c       |   4 +
>   src/qemu/qemu_monitor.c      |  23 +++--
>   src/qemu/qemu_monitor.h      |  16 +++-
>   src/qemu/qemu_monitor_json.c |  66 +++++++++++++++
>   src/qemu/qemu_monitor_json.h |  13 +++
>   src/qemu/qemu_monitor_text.c |  88 -------------------
>   src/qemu/qemu_monitor_text.h |  29 -------
>   src/qemu/qemu_snapshot.c     | 158 ++++++++++++++++++++++++++++++++---
>   14 files changed, 267 insertions(+), 160 deletions(-)
>   delete mode 100644 src/qemu/qemu_monitor_text.c
>   delete mode 100644 src/qemu/qemu_monitor_text.h
>
Re: [PATCH 0/4] Rework qemu internal active snapshots to use QMP
Posted by Denis V. Lunev via Devel 1 month, 1 week ago
On 7/26/24 12:35, Nikolai Barybin wrote:
> Hello everyone! This is a ping email
>
> On 7/16/24 00:42, Nikolai Barybin wrote:
>> These patches make use of QMP recently added snapshot-save/delete
>> commands and reaps HMP savevm/deletevm. The usage of HMP commands
>> are highly discouraged by QEMU.
>>
>> Nikolai Barybin (4):
>>    qemu monitor: add snaphot-save/delete QMP commands
>>    qemu blockjob: add snapshot-save/delete job types
>>    qemu snapshot: use QMP snapshot-save/delete for internal snapshots
>>    qemu monitor: reap qemu_monitor_text
>>
>>   po/POTFILES                  |   1 -
>>   po/libvirt.pot               |  18 ----
>>   src/qemu/meson.build         |   1 -
>>   src/qemu/qemu_block.c        |   2 +
>>   src/qemu/qemu_blockjob.c     |   6 +-
>>   src/qemu/qemu_blockjob.h     |   2 +
>>   src/qemu/qemu_domain.c       |   4 +
>>   src/qemu/qemu_monitor.c      |  23 +++--
>>   src/qemu/qemu_monitor.h      |  16 +++-
>>   src/qemu/qemu_monitor_json.c |  66 +++++++++++++++
>>   src/qemu/qemu_monitor_json.h |  13 +++
>>   src/qemu/qemu_monitor_text.c |  88 -------------------
>>   src/qemu/qemu_monitor_text.h |  29 -------
>>   src/qemu/qemu_snapshot.c     | 158 ++++++++++++++++++++++++++++++++---
>>   14 files changed, 267 insertions(+), 160 deletions(-)
>>   delete mode 100644 src/qemu/qemu_monitor_text.c
>>   delete mode 100644 src/qemu/qemu_monitor_text.h
>>
1. Please do not top-post
2. I believe you are pinging wrong thread, you should do that in v2