docs: use real examples for QEMU cli passthrough

[PATCH] docs: use real examples for QEMU cli passthrough

Daniel P. Berrangé posted 1 patch 1 month, 3 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20240712151858.372273-1-berrange@redhat.com

docs/drvqemu.rst | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH] docs: use real examples for QEMU cli passthrough

Posted by Daniel P. Berrangé 1 month, 3 weeks ago

User feedback has shown that the examples are not clear enough
to illustrate the cli passthrough concept in action.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 docs/drvqemu.rst | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/docs/drvqemu.rst b/docs/drvqemu.rst
index 1ee4b1e366..e52d9ffd47 100644
--- a/docs/drvqemu.rst
+++ b/docs/drvqemu.rst
@@ -595,8 +595,11 @@ Example:
        <emulator>/usr/bin/qemu-system-x86_64</emulator>
      </devices>
      <qemu:commandline>
-       <qemu:arg value='-newarg'/>
-       <qemu:env name='QEMU_ENV' value='VAL'/>
+       <qemu:arg value='-device'/>
+       <qemu:arg value='ipmi-bmc-sim,id=bmc0'/>
+       <qemu:arg value='-device'/>
+       <qemu:arg value='smbus-impi,bmc=bmc0'/>
+       <qemu:env name='QEMU_MODULE_DIR' value='/usr/lib64/qemu'/>
      </qemu:commandline>
    </domain>
 
-- 
2.45.1

Re: [PATCH] docs: use real examples for QEMU cli passthrough

Posted by Michal Prívozník 1 month, 3 weeks ago

On 7/12/24 17:18, Daniel P. Berrangé wrote:
> User feedback has shown that the examples are not clear enough
> to illustrate the cli passthrough concept in action.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  docs/drvqemu.rst | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
Trivial.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal