[PATCH] rpm: drop cyrus-sasl dep

Daniel P. Berrangé posted 1 patch 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20240606121043.512572-1-berrange@redhat.com
libvirt.spec.in | 2 --
1 file changed, 2 deletions(-)
[PATCH] rpm: drop cyrus-sasl dep
Posted by Daniel P. Berrangé 3 months ago
We link to libsasl2.so, so get a dep on cyrus-sasl-libs automatically.
The dep on cyrus-sasl-gssapi gets us the mechanism that matches our
default config.

The 'cyrus-sasl' package merely contains some man pages and the
saslauthd daemon, which is not required by libvirt. This dep appears
to have been redundant since we first added in

  commit 1b1d647439059b7e10fb94e1ade227fb695d7110
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   Wed Dec 5 15:24:15 2007 +0000

    Initial integration of SASL authentication, working for Kerberos only

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 libvirt.spec.in | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 1d3240ee6f..343015ad1d 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1055,8 +1055,6 @@ with some QEMU specific features of libvirt.
 
 %package libs
 Summary: Client side libraries
-# So remote clients can access libvirt over SSH tunnel
-Requires: cyrus-sasl
 # Needed by default sasl.conf - no onerous extra deps, since
 # 100's of other things on a system already pull in krb5-libs
 Requires: cyrus-sasl-gssapi
-- 
2.43.0
Re: [PATCH] rpm: drop cyrus-sasl dep
Posted by Michal Prívozník 3 months ago
On 6/6/24 14:10, Daniel P. Berrangé wrote:
> We link to libsasl2.so, so get a dep on cyrus-sasl-libs automatically.
> The dep on cyrus-sasl-gssapi gets us the mechanism that matches our
> default config.
> 
> The 'cyrus-sasl' package merely contains some man pages and the
> saslauthd daemon, which is not required by libvirt. This dep appears
> to have been redundant since we first added in
> 
>   commit 1b1d647439059b7e10fb94e1ade227fb695d7110
>   Author: Daniel P. Berrangé <berrange@redhat.com>
>   Date:   Wed Dec 5 15:24:15 2007 +0000
> 
>     Initial integration of SASL authentication, working for Kerberos only
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  libvirt.spec.in | 2 --
>  1 file changed, 2 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal