[PATCH 0/3] meson: Improve default firewall backend configuration

Andrea Bolognani posted 3 patches 3 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20240528154922.366266-1-abologna@redhat.com
libvirt.spec.in                  |  1 +
meson.build                      | 21 ++++++++++++++-------
meson_options.txt                |  3 +--
src/network/bridge_driver_conf.c |  6 +++++-
src/network/meson.build          |  6 ++++--
src/network/network.conf.in      | 13 +++++++------
6 files changed, 32 insertions(+), 18 deletions(-)
[PATCH 0/3] meson: Improve default firewall backend configuration
Posted by Andrea Bolognani 3 months, 1 week ago
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1308917840

See 1/3 for details.

Andrea Bolognani (3):
  meson: Improve default firewall backend configuration
  meson: Include firewall backend selection in summary
  rpm: Configure firewall backends explicitly

 libvirt.spec.in                  |  1 +
 meson.build                      | 21 ++++++++++++++-------
 meson_options.txt                |  3 +--
 src/network/bridge_driver_conf.c |  6 +++++-
 src/network/meson.build          |  6 ++++--
 src/network/network.conf.in      | 13 +++++++------
 6 files changed, 32 insertions(+), 18 deletions(-)

-- 
2.45.1
Re: [PATCH 0/3] meson: Improve default firewall backend configuration
Posted by Laine Stump 3 months, 1 week ago
On 5/28/24 11:49 AM, Andrea Bolognani wrote:
> Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1308917840
> 
> See 1/3 for details.
> 
> Andrea Bolognani (3):
>    meson: Improve default firewall backend configuration
>    meson: Include firewall backend selection in summary
>    rpm: Configure firewall backends explicitly

Reviewed-by: Laine Stump <laine@redhat.com>

Thanks for doing this - I had put "make the backend default selection 
better" on a *mental* list, but not a physical list, and then I forgot 
(easy to forget because doing things in a meson build file is for me an 
exercise in poking at it until it works correctly).

I've tried it out and it works as advertised. I would prefer to 
categorize this as a bugfix and push it before the release (so that we 
don't have the build-time config different in this release than in later 
releases)