This way we can avoid repeating it twice.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 libvirt.spec.in | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 329b923e8f..0d6f15460d 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -810,6 +810,9 @@ Summary: QEMU driver plugin for the libvirtd daemon
 Requires: libvirt-daemon-common = %{version}-%{release}
 Requires: libvirt-daemon-log = %{version}-%{release}
 Requires: libvirt-libs = %{version}-%{release}
+        %if %{with_ssh_proxy}
+Recommends: libvirt-ssh-proxy = %{version}-%{release}
+        %endif
 Requires: /usr/bin/qemu-img
 # For image compression
 Requires: gzip
@@ -904,9 +907,6 @@ Requires: libvirt-daemon-driver-nodedev = %{version}-%{release}
 Requires: libvirt-daemon-driver-nwfilter = %{version}-%{release}
 Requires: libvirt-daemon-driver-secret = %{version}-%{release}
 Requires: libvirt-daemon-driver-storage = %{version}-%{release}
-        %if %{with_ssh_proxy}
-Recommends: libvirt-ssh-proxy = %{version}-%{release}
-        %endif
 Requires: qemu
 
 %description daemon-qemu
@@ -935,9 +935,6 @@ Requires: libvirt-daemon-driver-nodedev = %{version}-%{release}
 Requires: libvirt-daemon-driver-nwfilter = %{version}-%{release}
 Requires: libvirt-daemon-driver-secret = %{version}-%{release}
 Requires: libvirt-daemon-driver-storage = %{version}-%{release}
-        %if %{with_ssh_proxy}
-Recommends: libvirt-ssh-proxy = %{version}-%{release}
-        %endif
 Requires: qemu-kvm
 
 %description daemon-kvm
-- 
2.45.0

On Thu, May 16, 2024 at 10:24:21AM +0200, Andrea Bolognani wrote:
> This way we can avoid repeating it twice.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  libvirt.spec.in | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)

This shouldn't be done. It will pull in the SSH proxy on every
install of the 'libvirt-ademon-driver-qemu' RPM which is not
desirable - this RPM is supposed to be providing the bare
minimum install with no optional extras.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|