[v2] node_dev_udev: use workerpool and improve nodedev events

[PATCH v2 20/20] node_device_udev: remove incorrect G_GNUC_UNUSED

Posted by Marc Hartmayer 1 year, 9 months ago

Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
---
 src/node_device/node_device_udev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
index 14d44d5bcd0e..cc725997a39e 100644
--- a/src/node_device/node_device_udev.c
+++ b/src/node_device/node_device_udev.c
@@ -791,7 +791,7 @@ udevGetSCSIType(virNodeDeviceDef *def G_GNUC_UNUSED,
 
 
 static int
-udevProcessSCSIDevice(struct udev_device *device G_GNUC_UNUSED,
+udevProcessSCSIDevice(struct udev_device *device,
                       virNodeDeviceDef *def)
 {
     int ret = -1;
-- 
2.34.1
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

Re: [PATCH v2 20/20] node_device_udev: remove incorrect G_GNUC_UNUSED

Posted by Boris Fiuczynski 1 year, 7 months ago

Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>

On 4/23/24 8:09 PM, Marc Hartmayer wrote:
> Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
> ---
>   src/node_device/node_device_udev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
> index 14d44d5bcd0e..cc725997a39e 100644
> --- a/src/node_device/node_device_udev.c
> +++ b/src/node_device/node_device_udev.c
> @@ -791,7 +791,7 @@ udevGetSCSIType(virNodeDeviceDef *def G_GNUC_UNUSED,
>   
>   
>   static int
> -udevProcessSCSIDevice(struct udev_device *device G_GNUC_UNUSED,
> +udevProcessSCSIDevice(struct udev_device *device,
>                         virNodeDeviceDef *def)
>   {
>       int ret = -1;

-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

Re: [PATCH v2 20/20] node_device_udev: remove incorrect G_GNUC_UNUSED

Posted by Boris Fiuczynski 1 year, 9 months ago

Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>

On 4/23/24 20:09, Marc Hartmayer wrote:
> Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
> ---
>   src/node_device/node_device_udev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
> index 14d44d5bcd0e..cc725997a39e 100644
> --- a/src/node_device/node_device_udev.c
> +++ b/src/node_device/node_device_udev.c
> @@ -791,7 +791,7 @@ udevGetSCSIType(virNodeDeviceDef *def G_GNUC_UNUSED,
>   
>   
>   static int
> -udevProcessSCSIDevice(struct udev_device *device G_GNUC_UNUSED,
> +udevProcessSCSIDevice(struct udev_device *device,
>                         virNodeDeviceDef *def)
>   {
>       int ret = -1;

-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org