[PATCH v2 23/27] rpm: drop BuildRequires for iptables and ebtables

Laine Stump posted 27 patches 1 year, 9 months ago
There is a newer version of this series
[PATCH v2 23/27] rpm: drop BuildRequires for iptables and ebtables
Posted by Laine Stump 1 year, 9 months ago
The only reason for requiring these was so that meson could search for
the binary location, and the previous patch eliminated that, so we no
longer need them at build time.

Signed-off-by: Laine Stump <laine@redhat.com>
---
 libvirt.spec.in | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index bde25c6f6e..05f7a7e7c0 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -356,8 +356,6 @@ BuildRequires: sanlock-devel >= 2.4
 BuildRequires: libpcap-devel >= 1.5.0
 BuildRequires: libnl3-devel
 BuildRequires: libselinux-devel
-BuildRequires: iptables
-BuildRequires: ebtables
 # For modprobe
 BuildRequires: kmod
 BuildRequires: cyrus-sasl-devel
-- 
2.44.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH v2 23/27] rpm: drop BuildRequires for iptables and ebtables
Posted by Daniel P. Berrangé 1 year, 9 months ago
On Sun, Apr 21, 2024 at 10:53:31PM -0400, Laine Stump wrote:
> The only reason for requiring these was so that meson could search for
> the binary location, and the previous patch eliminated that, so we no
> longer need them at build time.
> 
> Signed-off-by: Laine Stump <laine@redhat.com>
> ---
>  libvirt.spec.in | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

though I'd suggest it could just be squashed into the previous patch

> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index bde25c6f6e..05f7a7e7c0 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -356,8 +356,6 @@ BuildRequires: sanlock-devel >= 2.4
>  BuildRequires: libpcap-devel >= 1.5.0
>  BuildRequires: libnl3-devel
>  BuildRequires: libselinux-devel
> -BuildRequires: iptables
> -BuildRequires: ebtables
>  # For modprobe
>  BuildRequires: kmod
>  BuildRequires: cyrus-sasl-devel
> -- 
> 2.44.0
> _______________________________________________
> Devel mailing list -- devel@lists.libvirt.org
> To unsubscribe send an email to devel-leave@lists.libvirt.org

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org