[RFC PATCH v1 1/5] node_device_udev: Remove the timeout if the data is disposed

Marc Hartmayer posted 5 patches 1 year, 10 months ago
[RFC PATCH v1 1/5] node_device_udev: Remove the timeout if the data is disposed
Posted by Marc Hartmayer 1 year, 10 months ago
Remove the timeout when the udevEventData is disposed, analogous to priv->watch.

Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
---
 src/node_device/node_device_udev.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
index f1e402f8f7f6..b4bdfbeec841 100644
--- a/src/node_device/node_device_udev.c
+++ b/src/node_device/node_device_udev.c
@@ -88,6 +88,9 @@ udevEventDataDispose(void *obj)
     if (priv->watch != -1)
         virEventRemoveHandle(priv->watch);
 
+    if (priv->mdevctlTimeout > 0)
+        virEventRemoveTimeout(priv->mdevctlTimeout);
+
     if (!priv->udev_monitor)
         return;
 
-- 
2.34.1
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [RFC PATCH v1 1/5] node_device_udev: Remove the timeout if the data is disposed
Posted by Boris Fiuczynski 1 year, 10 months ago
Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>

On 4/3/24 16:03, Marc Hartmayer wrote:
> Remove the timeout when the udevEventData is disposed, analogous to priv->watch.
> 
> Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
> ---
>   src/node_device/node_device_udev.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
> index f1e402f8f7f6..b4bdfbeec841 100644
> --- a/src/node_device/node_device_udev.c
> +++ b/src/node_device/node_device_udev.c
> @@ -88,6 +88,9 @@ udevEventDataDispose(void *obj)
>       if (priv->watch != -1)
>           virEventRemoveHandle(priv->watch);
>   
> +    if (priv->mdevctlTimeout > 0)
> +        virEventRemoveTimeout(priv->mdevctlTimeout);
> +
>       if (!priv->udev_monitor)
>           return;
>   

-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org