[PATCH 03/10] security: Drop virSecurity(DAC|SELinux)RestoreImageLabelSingle()

Andrea Bolognani posted 10 patches 1 year, 10 months ago
There is a newer version of this series
[PATCH 03/10] security: Drop virSecurity(DAC|SELinux)RestoreImageLabelSingle()
Posted by Andrea Bolognani 1 year, 10 months ago
Each one only has a single, trivial caller.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/security/security_dac.c     | 21 ++++-----------------
 src/security/security_selinux.c | 21 ++++-----------------
 2 files changed, 8 insertions(+), 34 deletions(-)

diff --git a/src/security/security_dac.c b/src/security/security_dac.c
index 7421496fc9..9c24a1c4a8 100644
--- a/src/security/security_dac.c
+++ b/src/security/security_dac.c
@@ -972,10 +972,10 @@ virSecurityDACSetImageLabel(virSecurityManager *mgr,
 }
 
 static int
-virSecurityDACRestoreImageLabelSingle(virSecurityManager *mgr,
-                                      virDomainDef *def,
-                                      virStorageSource *src,
-                                      bool migrated)
+virSecurityDACRestoreImageLabelInt(virSecurityManager *mgr,
+                                   virDomainDef *def,
+                                   virStorageSource *src,
+                                   bool migrated)
 {
     virSecurityDACData *priv = virSecurityManagerGetPrivateData(mgr);
     virSecurityLabelDef *secdef;
@@ -1047,19 +1047,6 @@ virSecurityDACRestoreImageLabelSingle(virSecurityManager *mgr,
 }
 
 
-static int
-virSecurityDACRestoreImageLabelInt(virSecurityManager *mgr,
-                                   virDomainDef *def,
-                                   virStorageSource *src,
-                                   bool migrated)
-{
-    if (virSecurityDACRestoreImageLabelSingle(mgr, def, src, migrated) < 0)
-        return -1;
-
-    return 0;
-}
-
-
 static int
 virSecurityDACRestoreImageLabel(virSecurityManager *mgr,
                                 virDomainDef *def,
diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c
index ffad058d9a..d491435ae1 100644
--- a/src/security/security_selinux.c
+++ b/src/security/security_selinux.c
@@ -1774,10 +1774,10 @@ virSecuritySELinuxRestoreTPMFileLabelInt(virSecurityManager *mgr,
 
 
 static int
-virSecuritySELinuxRestoreImageLabelSingle(virSecurityManager *mgr,
-                                          virDomainDef *def,
-                                          virStorageSource *src,
-                                          bool migrated)
+virSecuritySELinuxRestoreImageLabelInt(virSecurityManager *mgr,
+                                       virDomainDef *def,
+                                       virStorageSource *src,
+                                       bool migrated)
 {
     virSecurityLabelDef *seclabel;
     virSecurityDeviceLabelDef *disk_seclabel;
@@ -1863,19 +1863,6 @@ virSecuritySELinuxRestoreImageLabelSingle(virSecurityManager *mgr,
 }
 
 
-static int
-virSecuritySELinuxRestoreImageLabelInt(virSecurityManager *mgr,
-                                       virDomainDef *def,
-                                       virStorageSource *src,
-                                       bool migrated)
-{
-    if (virSecuritySELinuxRestoreImageLabelSingle(mgr, def, src, migrated) < 0)
-        return -1;
-
-    return 0;
-}
-
-
 static int
 virSecuritySELinuxRestoreImageLabel(virSecurityManager *mgr,
                                     virDomainDef *def,
-- 
2.44.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH 03/10] security: Drop virSecurity(DAC|SELinux)RestoreImageLabelSingle()
Posted by Stefan Berger 1 year, 10 months ago

On 3/20/24 05:19, Andrea Bolognani wrote:
> Each one only has a single, trivial caller.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>

Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH 03/10] security: Drop virSecurity(DAC|SELinux)RestoreImageLabelSingle()
Posted by Peter Krempa 1 year, 10 months ago
On Wed, Mar 20, 2024 at 10:19:08 +0100, Andrea Bolognani wrote:
> Each one only has a single, trivial caller.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  src/security/security_dac.c     | 21 ++++-----------------
>  src/security/security_selinux.c | 21 ++++-----------------
>  2 files changed, 8 insertions(+), 34 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org