remote_protocol: Fix ACL on REMOTE_PROC_NODE_DEVICE_DEFINE_XML

[PATCH] remote_protocol: Fix ACL on REMOTE_PROC_NODE_DEVICE_DEFINE_XML

Boris Fiuczynski posted 1 patch 1 month, 4 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20240228184608.16372-1-fiuczy@linux.ibm.com

src/remote/remote_protocol.x | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] remote_protocol: Fix ACL on REMOTE_PROC_NODE_DEVICE_DEFINE_XML

Posted by Boris Fiuczynski 1 month, 4 weeks ago

Adding 'save' ACL to REMOTE_PROC_NODE_DEVICE_DEFINE_XML to make
REMOTE_PROC_NODE_DEVICE_UPDATE ACLs meaningful.

Fixes: 69f9e7dbc24657e85761f03574779540d0f18315
Signed-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
---
 src/remote/remote_protocol.x | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
index ffe865965d..71ae0cf6c1 100644
--- a/src/remote/remote_protocol.x
+++ b/src/remote/remote_protocol.x
@@ -6903,6 +6903,7 @@ enum remote_procedure {
     /**
      * @generate: both
      * @acl: node_device:write
+     * @acl: node_device:save
      */
     REMOTE_PROC_NODE_DEVICE_DEFINE_XML = 428,
 
-- 
2.42.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

Re: [PATCH] remote_protocol: Fix ACL on REMOTE_PROC_NODE_DEVICE_DEFINE_XML

Posted by Michal Prívozník 1 month, 4 weeks ago

On 2/28/24 19:46, Boris Fiuczynski wrote:
> Adding 'save' ACL to REMOTE_PROC_NODE_DEVICE_DEFINE_XML to make
> REMOTE_PROC_NODE_DEVICE_UPDATE ACLs meaningful.
> 
> Fixes: 69f9e7dbc24657e85761f03574779540d0f18315
> Signed-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
> ---
>  src/remote/remote_protocol.x | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
> index ffe865965d..71ae0cf6c1 100644
> --- a/src/remote/remote_protocol.x
> +++ b/src/remote/remote_protocol.x
> @@ -6903,6 +6903,7 @@ enum remote_procedure {
>      /**
>       * @generate: both
>       * @acl: node_device:write
> +     * @acl: node_device:save
>       */
>      REMOTE_PROC_NODE_DEVICE_DEFINE_XML = 428,
>  

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org