This started out as a way to make the upcoming loongarch64 support
slightly nicer to implement, but ended up including a bunch of
tangentially related changes.

Since trying to unentangle them would just result in a bunch of
smaller series that still have dependencies on each other, I'm just
sending everything at once.

Andrea Bolognani (18):
  tests: Add devices to pseries-phb-simple
  tests: Add pseries-phb-user-alias
  qemu: Fix handling of user aliases for default PHB
  tests: Drop aarch64-virtio-pci-default
  tests: Add {aarch64,riscv64}-virt-headless-mmio
  tests: Drop various redundant tests
  tests: Simplify balloon-mmio-deflate
  tests: Request virtio-mmio for balloon-mmio-deflate
  qemu: Stop checking QEMU_CAPS_OBJECT_GPEX
  qemu: Retire QEMU_CAPS_OBJECT_GPEX
  qemu: Improve qemuDomainSupportsPCI()
  qemu: Move qemuDomainSupportsPCIMultibus()
  qemu: Improve qemuDomainSupportsPCIMultibus()
  tests: Add *-default-net
  qemu: Improve qemuDomainDefaultNetModel()
  tests: Add *-default-devices
  qemu: Don't add memballoon by default on RISC-V
  qemu: Default to no USB and no memballoon for new architectures

 src/qemu/qemu_alias.c                         |  2 +-
 src/qemu/qemu_capabilities.c                  | 31 +-----
 src/qemu/qemu_capabilities.h                  |  4 +-
 src/qemu/qemu_command.c                       | 25 ++++-
 src/qemu/qemu_domain.c                        | 94 ++++++++++++-------
 src/qemu/qemu_domain.h                        |  4 +-
 src/qemu/qemu_domain_address.c                |  2 +-
 .../caps_4.2.0_aarch64.xml                    |  1 -
 .../caps_5.0.0_aarch64.xml                    |  1 -
 .../caps_5.0.0_riscv64.xml                    |  1 -
 .../caps_5.2.0_aarch64.xml                    |  1 -
 .../caps_5.2.0_riscv64.xml                    |  1 -
 .../caps_5.2.0_x86_64.xml                     |  1 -
 .../caps_6.0.0_aarch64.xml                    |  1 -
 .../caps_6.0.0_x86_64.xml                     |  1 -
 .../caps_6.1.0_x86_64.xml                     |  1 -
 .../caps_6.2.0_aarch64.xml                    |  1 -
 .../caps_6.2.0_x86_64.xml                     |  1 -
 .../caps_7.0.0_aarch64+hvf.xml                |  1 -
 .../caps_7.0.0_aarch64.xml                    |  1 -
 .../caps_7.0.0_x86_64.xml                     |  1 -
 .../caps_7.1.0_x86_64.xml                     |  1 -
 .../caps_7.2.0_x86_64+hvf.xml                 |  1 -
 .../caps_7.2.0_x86_64.xml                     |  1 -
 .../caps_8.0.0_riscv64.xml                    |  1 -
 .../caps_8.0.0_x86_64.xml                     |  1 -
 .../caps_8.1.0_x86_64.xml                     |  1 -
 .../caps_8.2.0_aarch64.xml                    |  1 -
 .../caps_8.2.0_x86_64.xml                     |  1 -
 .../caps_9.0.0_x86_64.xml                     |  1 -
 ...ch64-aavmf-virtio-mmio.aarch64-latest.args | 46 ---------
 .../aarch64-aavmf-virtio-mmio.xml             | 49 ----------
 ...arch64-default-devices.aarch64-latest.args | 31 ++++++
 .../aarch64-default-devices.xml               | 12 +++
 .../aarch64-default-net.aarch64-latest.args   | 35 +++++++
 .../qemuxml2argvdata/aarch64-default-net.xml  | 17 ++++
 ...h64-virt-headless-mmio.aarch64-latest.args | 48 ++++++++++
 .../aarch64-virt-headless-mmio.xml            | 48 ++++++++++
 ...ch64-virtio-pci-default.aarch64-4.2.0.args | 54 -----------
 ...h64-virtio-pci-default.aarch64-latest.args | 54 -----------
 .../aarch64-virtio-pci-default.xml            | 44 ---------
 .../arm-virt-virtio.aarch64-latest.args       | 54 -----------
 tests/qemuxml2argvdata/arm-virt-virtio.xml    | 45 ---------
 .../balloon-mmio-deflate.aarch64-latest.args  |  4 -
 .../qemuxml2argvdata/balloon-mmio-deflate.xml | 17 +---
 ...> ppc64-default-devices.ppc64-latest.args} | 22 ++---
 .../ppc64-default-devices.xml                 | 12 +++
 ...gs => ppc64-default-net.ppc64-latest.args} | 22 ++---
 ...s-phb-simple.xml => ppc64-default-net.xml} | 12 +--
 .../pseries-phb-simple.ppc64-latest.args      |  5 +-
 tests/qemuxml2argvdata/pseries-phb-simple.xml | 11 ++-
 ... pseries-phb-user-alias.ppc64-latest.args} |  7 +-
 .../pseries-phb-user-alias.xml                | 30 ++++++
 ...iscv64-default-devices.riscv64-latest.args | 30 ++++++
 .../riscv64-default-devices.xml               | 12 +++
 .../riscv64-default-net.riscv64-latest.args   | 34 +++++++
 .../qemuxml2argvdata/riscv64-default-net.xml  | 17 ++++
 ...64-virt-headless-mmio.riscv64-latest.args} | 39 ++++----
 .../riscv64-virt-headless-mmio.xml            | 43 +++++++++
 .../riscv64-virt-pci.riscv64-latest.args      | 35 -------
 tests/qemuxml2argvdata/riscv64-virt-pci.xml   | 24 -----
 .../riscv64-virt.riscv64-latest.args          | 38 --------
 tests/qemuxml2argvdata/riscv64-virt.xml       | 19 ----
 .../s390x-default-devices.s390x-latest.args   | 32 +++++++
 .../s390x-default-devices.xml                 | 12 +++
 .../s390x-default-net.s390x-latest.args       | 33 +++++++
 tests/qemuxml2argvdata/s390x-default-net.xml  | 17 ++++
 .../x86_64-default-devices.x86_64-latest.args | 33 +++++++
 .../x86_64-default-devices.xml                | 12 +++
 .../x86_64-default-net.x86_64-latest.args     | 33 +++++++
 tests/qemuxml2argvdata/x86_64-default-net.xml | 17 ++++
 tests/qemuxml2argvtest.c                      | 47 ++++------
 ...rch64-aavmf-virtio-mmio.aarch64-latest.xml | 56 -----------
 ...aarch64-default-devices.aarch64-latest.xml | 26 +++++
 .../aarch64-default-net.aarch64-latest.xml    | 43 +++++++++
 ...ch64-virt-headless-mmio.aarch64-latest.xml | 71 ++++++++++++++
 ...ch64-virtio-pci-default.aarch64-latest.xml | 94 -------------------
 ...=> ppc64-default-devices.ppc64-latest.xml} | 24 ++---
 ...xml => ppc64-default-net.ppc64-latest.xml} | 23 ++---
 .../pseries-phb-simple.ppc64-latest.xml       | 14 ++-
 ...> pseries-phb-user-alias.ppc64-latest.xml} | 18 +++-
 ...riscv64-default-devices.riscv64-latest.xml | 20 ++++
 .../riscv64-default-net.riscv64-latest.xml    | 37 ++++++++
 ...cv64-virt-headless-mmio.riscv64-latest.xml | 58 ++++++++++++
 .../s390x-default-devices.s390x-latest.xml    | 27 ++++++
 .../s390x-default-net.s390x-latest.xml        | 31 ++++++
 .../x86_64-default-devices.x86_64-latest.xml  | 31 ++++++
 .../x86_64-default-net.x86_64-latest.xml      | 32 +++++++
 tests/qemuxml2xmltest.c                       | 21 ++++-
 89 files changed, 1162 insertions(+), 855 deletions(-)
 delete mode 100644 tests/qemuxml2argvdata/aarch64-aavmf-virtio-mmio.aarch64-latest.args
 delete mode 100644 tests/qemuxml2argvdata/aarch64-aavmf-virtio-mmio.xml
 create mode 100644 tests/qemuxml2argvdata/aarch64-default-devices.aarch64-latest.args
 create mode 100644 tests/qemuxml2argvdata/aarch64-default-devices.xml
 create mode 100644 tests/qemuxml2argvdata/aarch64-default-net.aarch64-latest.args
 create mode 100644 tests/qemuxml2argvdata/aarch64-default-net.xml
 create mode 100644 tests/qemuxml2argvdata/aarch64-virt-headless-mmio.aarch64-latest.args
 create mode 100644 tests/qemuxml2argvdata/aarch64-virt-headless-mmio.xml
 delete mode 100644 tests/qemuxml2argvdata/aarch64-virtio-pci-default.aarch64-4.2.0.args
 delete mode 100644 tests/qemuxml2argvdata/aarch64-virtio-pci-default.aarch64-latest.args
 delete mode 100644 tests/qemuxml2argvdata/aarch64-virtio-pci-default.xml
 delete mode 100644 tests/qemuxml2argvdata/arm-virt-virtio.aarch64-latest.args
 delete mode 100644 tests/qemuxml2argvdata/arm-virt-virtio.xml
 copy tests/qemuxml2argvdata/{pseries-phb-simple.ppc64-latest.args => ppc64-default-devices.ppc64-latest.args} (56%)
 create mode 100644 tests/qemuxml2argvdata/ppc64-default-devices.xml
 copy tests/qemuxml2argvdata/{pseries-phb-simple.ppc64-latest.args => ppc64-default-net.ppc64-latest.args} (56%)
 copy tests/qemuxml2argvdata/{pseries-phb-simple.xml => ppc64-default-net.xml} (55%)
 copy tests/qemuxml2argvdata/{pseries-phb-simple.ppc64-latest.args => pseries-phb-user-alias.ppc64-latest.args} (75%)
 create mode 100644 tests/qemuxml2argvdata/pseries-phb-user-alias.xml
 create mode 100644 tests/qemuxml2argvdata/riscv64-default-devices.riscv64-latest.args
 create mode 100644 tests/qemuxml2argvdata/riscv64-default-devices.xml
 create mode 100644 tests/qemuxml2argvdata/riscv64-default-net.riscv64-latest.args
 create mode 100644 tests/qemuxml2argvdata/riscv64-default-net.xml
 rename tests/qemuxml2argvdata/{aarch64-virt-virtio-MMIO.aarch64.latest.args => riscv64-virt-headless-mmio.riscv64-latest.args} (50%)
 create mode 100644 tests/qemuxml2argvdata/riscv64-virt-headless-mmio.xml
 delete mode 100644 tests/qemuxml2argvdata/riscv64-virt-pci.riscv64-latest.args
 delete mode 100644 tests/qemuxml2argvdata/riscv64-virt-pci.xml
 delete mode 100644 tests/qemuxml2argvdata/riscv64-virt.riscv64-latest.args
 delete mode 100644 tests/qemuxml2argvdata/riscv64-virt.xml
 create mode 100644 tests/qemuxml2argvdata/s390x-default-devices.s390x-latest.args
 create mode 100644 tests/qemuxml2argvdata/s390x-default-devices.xml
 create mode 100644 tests/qemuxml2argvdata/s390x-default-net.s390x-latest.args
 create mode 100644 tests/qemuxml2argvdata/s390x-default-net.xml
 create mode 100644 tests/qemuxml2argvdata/x86_64-default-devices.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/x86_64-default-devices.xml
 create mode 100644 tests/qemuxml2argvdata/x86_64-default-net.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/x86_64-default-net.xml
 delete mode 100644 tests/qemuxml2xmloutdata/aarch64-aavmf-virtio-mmio.aarch64-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/aarch64-default-devices.aarch64-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/aarch64-default-net.aarch64-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/aarch64-virt-headless-mmio.aarch64-latest.xml
 delete mode 100644 tests/qemuxml2xmloutdata/aarch64-virtio-pci-default.aarch64-latest.xml
 copy tests/qemuxml2xmloutdata/{pseries-phb-simple.ppc64-latest.xml => ppc64-default-devices.ppc64-latest.xml} (58%)
 copy tests/qemuxml2xmloutdata/{pseries-phb-simple.ppc64-latest.xml => ppc64-default-net.ppc64-latest.xml} (63%)
 copy tests/qemuxml2xmloutdata/{pseries-phb-simple.ppc64-latest.xml => pseries-phb-user-alias.ppc64-latest.xml} (69%)
 create mode 100644 tests/qemuxml2xmloutdata/riscv64-default-devices.riscv64-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/riscv64-default-net.riscv64-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/riscv64-virt-headless-mmio.riscv64-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/s390x-default-devices.s390x-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/s390x-default-net.s390x-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/x86_64-default-devices.x86_64-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/x86_64-default-net.x86_64-latest.xml

-- 
2.43.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

On Wed, Jan 17, 2024 at 10:54:33 +0100, Andrea Bolognani wrote:
> This started out as a way to make the upcoming loongarch64 support
> slightly nicer to implement, but ended up including a bunch of
> tangentially related changes.
> 
> Since trying to unentangle them would just result in a bunch of
> smaller series that still have dependencies on each other, I'm just
> sending everything at once.

Note that this series modifies many test cases across qemuxml2argvtest
and qemuxml2xmltest. Since my two series:

[PATCH 00/23] qemu XML testing improvements, part 2 - enforcement of xml->xml testing
[PATCH 0/7] qemu XML testing improvements, part 3 - xmlout->xmlout testing and fixes

also modify how testing is done and in the end unify qemuxml2xmltest
with argument testing it would be preferential if that goes in first.

Please give it a review.
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

On Wed, Jan 17, 2024 at 12:57:51PM +0100, Peter Krempa wrote:
> On Wed, Jan 17, 2024 at 10:54:33 +0100, Andrea Bolognani wrote:
> > This started out as a way to make the upcoming loongarch64 support
> > slightly nicer to implement, but ended up including a bunch of
> > tangentially related changes.
> >
> > Since trying to unentangle them would just result in a bunch of
> > smaller series that still have dependencies on each other, I'm just
> > sending everything at once.
>
> Note that this series modifies many test cases across qemuxml2argvtest
> and qemuxml2xmltest. Since my two series:
>
> [PATCH 00/23] qemu XML testing improvements, part 2 - enforcement of xml->xml testing
> [PATCH 0/7] qemu XML testing improvements, part 3 - xmlout->xmlout testing and fixes
>
> also modify how testing is done and in the end unify qemuxml2xmltest
> with argument testing it would be preferential if that goes in first.
>
> Please give it a review.

The patches that have been ACKed so far (1-13) mostly drop test
cases, so the impact on your series should be fairly small. How about
I push those patches, then review your series before respinning the
remainder of mine? Or do you think that would introduce a lot of
additional burden for you, and I should rather hold everything for
now?

-- 
Andrea Bolognani / Red Hat / Virtualization
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

On Wed, Jan 17, 2024 at 10:45:54 -0500, Andrea Bolognani wrote:
> On Wed, Jan 17, 2024 at 12:57:51PM +0100, Peter Krempa wrote:
> > On Wed, Jan 17, 2024 at 10:54:33 +0100, Andrea Bolognani wrote:
> > > This started out as a way to make the upcoming loongarch64 support
> > > slightly nicer to implement, but ended up including a bunch of
> > > tangentially related changes.
> > >
> > > Since trying to unentangle them would just result in a bunch of
> > > smaller series that still have dependencies on each other, I'm just
> > > sending everything at once.
> >
> > Note that this series modifies many test cases across qemuxml2argvtest
> > and qemuxml2xmltest. Since my two series:
> >
> > [PATCH 00/23] qemu XML testing improvements, part 2 - enforcement of xml->xml testing
> > [PATCH 0/7] qemu XML testing improvements, part 3 - xmlout->xmlout testing and fixes
> >
> > also modify how testing is done and in the end unify qemuxml2xmltest
> > with argument testing it would be preferential if that goes in first.
> >
> > Please give it a review.
> 
> The patches that have been ACKed so far (1-13) mostly drop test
> cases, so the impact on your series should be fairly small. How about
> I push those patches, then review your series before respinning the
> remainder of mine? Or do you think that would introduce a lot of
> additional burden for you, and I should rather hold everything for
> now?

Jano already R-b'd my patches so I'll push them right after the
pipelines finish.
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

On Wed, Jan 17, 2024 at 04:48:57PM +0100, Peter Krempa wrote:
> On Wed, Jan 17, 2024 at 10:45:54 -0500, Andrea Bolognani wrote:
> > On Wed, Jan 17, 2024 at 12:57:51PM +0100, Peter Krempa wrote:
> > > On Wed, Jan 17, 2024 at 10:54:33 +0100, Andrea Bolognani wrote:
> > > > This started out as a way to make the upcoming loongarch64 support
> > > > slightly nicer to implement, but ended up including a bunch of
> > > > tangentially related changes.
> > > >
> > > > Since trying to unentangle them would just result in a bunch of
> > > > smaller series that still have dependencies on each other, I'm just
> > > > sending everything at once.
> > >
> > > Note that this series modifies many test cases across qemuxml2argvtest
> > > and qemuxml2xmltest. Since my two series:
> > >
> > > [PATCH 00/23] qemu XML testing improvements, part 2 - enforcement of xml->xml testing
> > > [PATCH 0/7] qemu XML testing improvements, part 3 - xmlout->xmlout testing and fixes
> > >
> > > also modify how testing is done and in the end unify qemuxml2xmltest
> > > with argument testing it would be preferential if that goes in first.
> > >
> > > Please give it a review.
> >
> > The patches that have been ACKed so far (1-13) mostly drop test
> > cases, so the impact on your series should be fairly small. How about
> > I push those patches, then review your series before respinning the
> > remainder of mine? Or do you think that would introduce a lot of
> > additional burden for you, and I should rather hold everything for
> > now?
>
> Jano already R-b'd my patches so I'll push them right after the
> pipelines finish.

Excellent :)

-- 
Andrea Bolognani / Red Hat / Virtualization
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org